From: Emil Tantilov <emil.s.tantilov@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 3/5] ixgbe: always call setup_mac_link for multispeed fiber
Date: Wed, 17 May 2017 15:17:51 -0700 [thread overview]
Message-ID: <20170517221751.15538.97694.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20170517221424.15538.5968.stgit@localhost6.localdomain6>
Remove the logic which would previously skip the link configuration
in the case where we are already at the requested speed in
ixgbe_setup_mac_link_multispeed_fiber().
By exiting early we are skipping the link configuration and as such
the driver may not always configure the PHY correctly for SFP+.
Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 18 ------------------
1 file changed, 18 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
index 3af6127..8a2e8bf8 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_common.c
@@ -4121,15 +4121,6 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw,
speedcnt++;
highest_link_speed = IXGBE_LINK_SPEED_10GB_FULL;
- /* If we already have link at this speed, just jump out */
- status = hw->mac.ops.check_link(hw, &link_speed, &link_up,
- false);
- if (status)
- return status;
-
- if (link_speed == IXGBE_LINK_SPEED_10GB_FULL && link_up)
- goto out;
-
/* Set the module link speed */
switch (hw->phy.media_type) {
case ixgbe_media_type_fiber:
@@ -4181,15 +4172,6 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw,
if (highest_link_speed == IXGBE_LINK_SPEED_UNKNOWN)
highest_link_speed = IXGBE_LINK_SPEED_1GB_FULL;
- /* If we already have link at this speed, just jump out */
- status = hw->mac.ops.check_link(hw, &link_speed, &link_up,
- false);
- if (status)
- return status;
-
- if (link_speed == IXGBE_LINK_SPEED_1GB_FULL && link_up)
- goto out;
-
/* Set the module link speed */
switch (hw->phy.media_type) {
case ixgbe_media_type_fiber:
next prev parent reply other threads:[~2017-05-17 22:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-17 22:17 [Intel-wired-lan] [PATCH 0/5] ixgbe: fixes for configuring link on x550a Emil Tantilov
2017-05-17 22:17 ` [Intel-wired-lan] [PATCH 1/5] ixgbe: correct CS4223/7 PHY identification Emil Tantilov
2017-05-18 23:55 ` Bowers, AndrewX
2017-05-17 22:17 ` [Intel-wired-lan] [PATCH 2/5] ixgbe: add write flush when configuring CS4223/7 Emil Tantilov
2017-05-18 23:56 ` Bowers, AndrewX
2017-05-17 22:17 ` Emil Tantilov [this message]
2017-05-18 22:39 ` [Intel-wired-lan] [PATCH 3/5] ixgbe: always call setup_mac_link for multispeed fiber Bowers, AndrewX
2017-05-17 22:17 ` [Intel-wired-lan] [PATCH 4/5] ixgbe: add missing configuration for rate select 1 Emil Tantilov
2017-05-18 22:39 ` Bowers, AndrewX
2017-05-17 22:18 ` [Intel-wired-lan] [PATCH 5/5] ixgbe: fix incorrect status check Emil Tantilov
2017-05-18 22:40 ` Bowers, AndrewX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170517221751.15538.97694.stgit@localhost6.localdomain6 \
--to=emil.s.tantilov@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox