From: Alice Michael <alice.michael@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next PATCH S82 2/9] i40evf: Clean-up flags for promisc mode to avoid high polling rate
Date: Fri, 3 Nov 2017 07:05:04 -0400 [thread overview]
Message-ID: <20171103110511.76793-2-alice.michael@intel.com> (raw)
In-Reply-To: <20171103110511.76793-1-alice.michael@intel.com>
From: Alexander Duyck <alexander.h.duyck@intel.com>
If you enabled and disabled promiscuous mode on a VF you could easily put
it into a state where it would start firing interrupts on all queues at a
rate of 50+ interrupts per second even though there was no traffic present.
The issue seems to have been a stray admin queue feature flag set that was
leaving us in a high polling rate for the adminq task.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
---
drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c
index 2719a05..feb95b6 100644
--- a/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c
+++ b/drivers/net/ethernet/intel/i40evf/i40evf_virtchnl.c
@@ -739,8 +739,10 @@ void i40evf_set_promiscuous(struct i40evf_adapter *adapter, int flags)
}
if (!flags) {
- adapter->flags &= ~I40EVF_FLAG_PROMISC_ON;
- adapter->aq_required &= ~I40EVF_FLAG_AQ_RELEASE_PROMISC;
+ adapter->flags &= ~(I40EVF_FLAG_PROMISC_ON |
+ I40EVF_FLAG_ALLMULTI_ON);
+ adapter->aq_required &= ~(I40EVF_FLAG_AQ_RELEASE_PROMISC |
+ I40EVF_FLAG_AQ_RELEASE_ALLMULTI);
dev_info(&adapter->pdev->dev, "Leaving promiscuous mode\n");
}
--
2.9.5
next prev parent reply other threads:[~2017-11-03 11:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 11:05 [Intel-wired-lan] [next PATCH S82 1/9] i40evf: Do not clear MSI-X PBA manually Alice Michael
2017-11-03 11:05 ` Alice Michael [this message]
2017-11-03 11:05 ` [Intel-wired-lan] [next PATCH S82 3/9] i40evf: Drop i40evf_fire_sw_int as it is prone to races Alice Michael
2017-11-03 20:08 ` Shannon Nelson
2017-11-03 11:05 ` [Intel-wired-lan] [next PATCH S82 4/9] i40e: change ppp name to ddp Alice Michael
2017-11-03 11:05 ` [Intel-wired-lan] [next PATCH S82 5/9] i40e: track id can be 0 Alice Michael
2017-11-03 11:05 ` [Intel-wired-lan] [next PATCH S82 6/9] i40e: Fix FLR reset timeout issue Alice Michael
2017-11-03 20:10 ` Shannon Nelson
2017-11-03 11:05 ` [Intel-wired-lan] [next PATCH S82 7/9] i40e: link_down_on_close private flag support Alice Michael
2017-11-03 11:05 ` [Intel-wired-lan] [next PATCH S82 8/9] i40evf: fix client notify of l2 params Alice Michael
2017-11-03 11:05 ` [Intel-wired-lan] [next PATCH S82 9/9] i40e: Suppress compilation warning on kernels older than 3.12 Alice Michael
2017-11-03 20:12 ` Shannon Nelson
2017-11-06 9:41 ` Jablonski, Pawel
2017-11-07 14:04 ` Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171103110511.76793-2-alice.michael@intel.com \
--to=alice.michael@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox