Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Tantilov <emil.s.tantilov@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 1/9] ixgbevf: use page_address offset from page
Date: Tue, 30 Jan 2018 16:51:12 -0800	[thread overview]
Message-ID: <20180131005112.19264.46341.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20180131005015.19264.44085.stgit@localhost6.localdomain6>

Based on commit 3456fd53421e
("igb: Use page_address offset from page instead of masking virtual address")

Update the handling of page addresses so that we always refer to them using
a void pointer, and try to use the consistent name of va indicating we are
working with a virtual address.

Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
---
 drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
index 9b3d43d..604b026 100644
--- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
+++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
@@ -795,7 +795,7 @@ static bool ixgbevf_add_rx_frag(struct ixgbevf_ring *rx_ring,
 				struct sk_buff *skb)
 {
 	struct page *page = rx_buffer->page;
-	unsigned char *va = page_address(page) + rx_buffer->page_offset;
+	void *va = page_address(page) + rx_buffer->page_offset;
 #if (PAGE_SIZE < 8192)
 	unsigned int truesize = IXGBEVF_RX_BUFSZ;
 #else
@@ -831,7 +831,7 @@ static bool ixgbevf_add_rx_frag(struct ixgbevf_ring *rx_ring,
 
 add_tail_frag:
 	skb_add_rx_frag(skb, skb_shinfo(skb)->nr_frags, page,
-			(unsigned long)va & ~PAGE_MASK, size, truesize);
+			va - page_address(page), size, truesize);
 
 	return ixgbevf_can_reuse_rx_page(rx_buffer, page, truesize);
 }
@@ -856,13 +856,12 @@ static struct sk_buff *ixgbevf_fetch_rx_buffer(struct ixgbevf_ring *rx_ring,
 				      DMA_FROM_DEVICE);
 
 	if (likely(!skb)) {
-		void *page_addr = page_address(page) +
-				  rx_buffer->page_offset;
+		void *va = page_address(page) + rx_buffer->page_offset;
 
 		/* prefetch first cache line of first page */
-		prefetch(page_addr);
+		prefetch(va);
 #if L1_CACHE_BYTES < 128
-		prefetch(page_addr + L1_CACHE_BYTES);
+		prefetch(va + L1_CACHE_BYTES);
 #endif
 
 		/* allocate a skb to store the frags */


  reply	other threads:[~2018-01-31  0:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-31  0:51 [Intel-wired-lan] [PATCH 0/9] ixgbevf: build_skb support and related changes Emil Tantilov
2018-01-31  0:51 ` Emil Tantilov [this message]
2018-02-26 15:55   ` [Intel-wired-lan] [PATCH 1/9] ixgbevf: use page_address offset from page Singh, Krishneil K
2018-01-31  0:51 ` [Intel-wired-lan] [PATCH 2/9] ixgbevf: add ethtool private flag for legacy Rx Emil Tantilov
2018-02-26 16:02   ` Singh, Krishneil K
2018-01-31  0:51 ` [Intel-wired-lan] [PATCH 3/9] ixgbevf: add support for using order 1 pages to receive large frames Emil Tantilov
2018-02-26 16:03   ` Singh, Krishneil K
2018-01-31  0:51 ` [Intel-wired-lan] [PATCH 4/9] ixgbevf: setup queue counts Emil Tantilov
2018-02-26 16:03   ` Singh, Krishneil K
2018-01-31  0:51 ` [Intel-wired-lan] [PATCH 5/9] ixgbevf: add support for padding packet Emil Tantilov
2018-02-26 16:04   ` Singh, Krishneil K
2018-01-31  0:51 ` [Intel-wired-lan] [PATCH 6/9] ixgbevf: make sure all frames fit minimum size requirements Emil Tantilov
2018-02-26 16:04   ` Singh, Krishneil K
2018-01-31  0:51 ` [Intel-wired-lan] [PATCH 7/9] ixgbevf: allocate the rings as part of q_vector Emil Tantilov
2018-02-26 16:05   ` Singh, Krishneil K
2018-01-31  0:51 ` [Intel-wired-lan] [PATCH 8/9] ixgbevf: break out Rx buffer page management Emil Tantilov
2018-02-26 16:05   ` Singh, Krishneil K
2018-01-31  0:51 ` [Intel-wired-lan] [PATCH 9/9] ixgbevf: add build_skb support Emil Tantilov
2018-02-26 16:05   ` Singh, Krishneil K

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180131005112.19264.46341.stgit@localhost6.localdomain6 \
    --to=emil.s.tantilov@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox