Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [next-queue PATCH v6 02/10] igb: Fix queue selection on MAC filters on i210
Date: Thu, 29 Mar 2018 14:07:43 -0700	[thread overview]
Message-ID: <20180329210751.11531-3-vinicius.gomes@intel.com> (raw)
In-Reply-To: <20180329210751.11531-1-vinicius.gomes@intel.com>

On the RAH registers there are semantic differences on the meaning of
the "queue" parameter for traffic steering depending on the controller
model: there is the 82575 meaning, which "queue" means a RX Hardware
Queue, and the i350 meaning, where it is a reception pool.

The previous behaviour was having no effect for i210 based controllers
because the QSEL bit of the RAH register wasn't being set.

This patch separates the condition in discrete cases, so the different
handling is clearer.

Fixes: 83c21335c876 ("igb: improve MAC filter handling")
Signed-off-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
---
 drivers/net/ethernet/intel/igb/igb_main.c | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index c1c0bc30a16d..0a79fef3c4fb 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -8748,12 +8748,17 @@ static void igb_rar_set_index(struct igb_adapter *adapter, u32 index)
 		if (is_valid_ether_addr(addr))
 			rar_high |= E1000_RAH_AV;
 
-		if (hw->mac.type == e1000_82575)
+		switch (hw->mac.type) {
+		case e1000_82575:
+		case e1000_i210:
 			rar_high |= E1000_RAH_POOL_1 *
-				    adapter->mac_table[index].queue;
-		else
+				      adapter->mac_table[index].queue;
+			break;
+		default:
 			rar_high |= E1000_RAH_POOL_1 <<
-				    adapter->mac_table[index].queue;
+				adapter->mac_table[index].queue;
+			break;
+		}
 	}
 
 	wr32(E1000_RAL(index), rar_low);
-- 
2.16.3


  parent reply	other threads:[~2018-03-29 21:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 21:07 [Intel-wired-lan] [next-queue PATCH v6 00/10] igb: offloading of receive filters Vinicius Costa Gomes
2018-03-29 21:07 ` [Intel-wired-lan] [next-queue PATCH v6 01/10] igb: Fix not adding filter elements to the list Vinicius Costa Gomes
2018-03-29 21:07 ` Vinicius Costa Gomes [this message]
2018-03-29 21:07 ` [Intel-wired-lan] [next-queue PATCH v6 03/10] igb: Enable the hardware traffic class feature bit for igb models Vinicius Costa Gomes
2018-03-29 21:07 ` [Intel-wired-lan] [next-queue PATCH v6 04/10] igb: Add support for MAC address filters specifying source addresses Vinicius Costa Gomes
2018-03-29 21:07 ` [Intel-wired-lan] [next-queue PATCH v6 05/10] igb: Add support for enabling queue steering in filters Vinicius Costa Gomes
2018-03-29 21:07 ` [Intel-wired-lan] [next-queue PATCH v6 06/10] igb: Allow filters to be added for the local MAC address Vinicius Costa Gomes
2018-03-29 21:07 ` [Intel-wired-lan] [next-queue PATCH v6 07/10] igb: Enable nfc filters to specify MAC addresses Vinicius Costa Gomes
2018-03-29 21:07 ` [Intel-wired-lan] [next-queue PATCH v6 08/10] igb: Add MAC address support for ethtool nftuple filters Vinicius Costa Gomes
2018-04-05  1:47   ` Brown, Aaron F
2018-04-05 17:59     ` Vinicius Costa Gomes
2018-04-07  2:11       ` Brown, Aaron F
2018-04-09 17:33         ` Vinicius Costa Gomes
2018-03-29 21:07 ` [Intel-wired-lan] [next-queue PATCH v6 09/10] igb: Add the skeletons for tc-flower offloading Vinicius Costa Gomes
2018-03-29 21:07 ` [Intel-wired-lan] [next-queue PATCH v6 10/10] igb: Add support for adding offloaded clsflower filters Vinicius Costa Gomes
2018-04-07  2:19   ` Brown, Aaron F
2018-04-09 17:36     ` Vinicius Costa Gomes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180329210751.11531-3-vinicius.gomes@intel.com \
    --to=vinicius.gomes@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox