From: Dan Carpenter <dan.carpenter@oracle.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [bug report] ixgbe: added Rx/Tx ring disable/enable functions
Date: Thu, 11 Oct 2018 14:47:51 +0300 [thread overview]
Message-ID: <20181011114751.GA21224@mwanda> (raw)
Hello Bj?rn T?pel,
This is a semi-automatic email about new static checker warnings.
The patch 024aa5800f32: "ixgbe: added Rx/Tx ring disable/enable
functions" from Oct 2, 2018, leads to the following Smatch complaint:
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c:10520 ixgbe_txrx_ring_enable()
error: we previously assumed 'xdp_ring' could be null (see line 10515)
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
10514 ixgbe_configure_tx_ring(adapter, tx_ring);
10515 if (xdp_ring)
^^^^^^^^
The patch adds a check for NULL.
10516 ixgbe_configure_tx_ring(adapter, xdp_ring);
10517 ixgbe_configure_rx_ring(adapter, rx_ring);
10518
10519 clear_bit(__IXGBE_TX_DISABLED, &tx_ring->state);
10520 clear_bit(__IXGBE_TX_DISABLED, &xdp_ring->state);
^^^^^^^^^^^^^^^
but it also adds an unchecked dereference.
10521 }
10522
regards,
dan carpenter
next reply other threads:[~2018-10-11 11:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 11:47 Dan Carpenter [this message]
2018-10-12 8:41 ` [Intel-wired-lan] [bug report] ixgbe: added Rx/Tx ring disable/enable functions =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181011114751.GA21224@mwanda \
--to=dan.carpenter@oracle.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox