From: Miroslav Lichvar <mlichvar@redhat.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [RFC PATCH] e1000e: allow non-monotonic SYSTIM readings
Date: Tue, 23 Oct 2018 13:31:59 +0200 [thread overview]
Message-ID: <20181023113159.GR4407@localhost> (raw)
In-Reply-To: <02874ECE860811409154E81DA85FBB5884CDDA0E@ORSMSX115.amr.corp.intel.com>
On Fri, Oct 19, 2018 at 04:56:02PM +0000, Keller, Jacob E wrote:
> > @@ -233,6 +237,9 @@ static void e1000e_systim_overflow_work(struct
> > work_struct *work)
> > struct e1000_hw *hw = &adapter->hw;
> > struct timespec64 ts;
> >
> > + /* Update the timecounter */
> > + timecounter_read(&adapter->tc);
> > +
>
> yea, we previously depended on the gettime64 to do timecounter_read implicitly.
>
> > adapter->ptp_clock_info.gettime64(&adapter->ptp_clock_info, &ts);
>
> Can't we drop this line now?
Yes. We can save the value returned by the timecounter_read call and
convert it to timespec for the debug message below. I'll send a new
patch.
> >
> > e_dbg("SYSTIM overflow check at %lld.%09lu\n",
Thanks,
--
Miroslav Lichvar
next prev parent reply other threads:[~2018-10-23 11:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 16:16 [Intel-wired-lan] [RFC PATCH] e1000e: allow non-monotonic SYSTIM readings Miroslav Lichvar
2018-10-19 16:56 ` Keller, Jacob E
2018-10-23 11:31 ` Miroslav Lichvar [this message]
2018-11-03 1:58 ` Brown, Aaron F
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181023113159.GR4407@localhost \
--to=mlichvar@redhat.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox