Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH S28 8/9] ice: change default number of receive descriptors
Date: Tue, 27 Aug 2019 06:13:53 -0700	[thread overview]
Message-ID: <20190827131354.12703-8-anthony.l.nguyen@intel.com> (raw)
In-Reply-To: <20190827131354.12703-1-anthony.l.nguyen@intel.com>

From: Jesse Brandeburg <jesse.brandeburg@intel.com>

The driver should start out with a reasonable number of descriptors that
can prevent drops due to a CPU being in a power management state.
Change the default number of descriptors to 2048.
The user can always change the value at runtime.  Transmit descriptor
counts are not modified because they don't need to change due to the
speed of the interface, or for power managed CPUs, but the code is
simplified to a fixed value for the transmit default.

Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
---
 drivers/net/ethernet/intel/ice/ice.h | 19 ++-----------------
 1 file changed, 2 insertions(+), 17 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h
index cd30fc87d7ea..36de705397f9 100644
--- a/drivers/net/ethernet/intel/ice/ice.h
+++ b/drivers/net/ethernet/intel/ice/ice.h
@@ -47,23 +47,8 @@ extern const char ice_drv_ver[];
 #define ICE_MIN_NUM_DESC	64
 #define ICE_MAX_NUM_DESC	8160
 #define ICE_DFLT_MIN_RX_DESC	512
-/* if the default number of Rx descriptors between ICE_MAX_NUM_DESC and the
- * number of descriptors to fill up an entire page is greater than or equal to
- * ICE_DFLT_MIN_RX_DESC set it based on page size, otherwise set it to
- * ICE_DFLT_MIN_RX_DESC
- */
-#define ICE_DFLT_NUM_RX_DESC \
-	min_t(u16, ICE_MAX_NUM_DESC, \
-	      max_t(u16, ALIGN(PAGE_SIZE / sizeof(union ice_32byte_rx_desc), \
-			       ICE_REQ_DESC_MULTIPLE), \
-		    ICE_DFLT_MIN_RX_DESC))
-/* set default number of Tx descriptors to the minimum between ICE_MAX_NUM_DESC
- * and the number of descriptors to fill up an entire page
- */
-#define ICE_DFLT_NUM_TX_DESC	min_t(u16, ICE_MAX_NUM_DESC, \
-				      ALIGN(PAGE_SIZE / \
-					    sizeof(struct ice_tx_desc), \
-					    ICE_REQ_DESC_MULTIPLE))
+#define ICE_DFLT_NUM_TX_DESC	256
+#define ICE_DFLT_NUM_RX_DESC	2048
 
 #define ICE_DFLT_TRAFFIC_CLASS	BIT(0)
 #define ICE_INT_NAME_STR_LEN	(IFNAMSIZ + 16)
-- 
2.20.1


  parent reply	other threads:[~2019-08-27 13:13 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-27 13:13 [Intel-wired-lan] [PATCH S28 1/9] ice: Reliably reset VFs Tony Nguyen
2019-08-27 13:13 ` [Intel-wired-lan] [PATCH S28 2/9] ice: report link down for VF when PF's queues are not enabled Tony Nguyen
2019-08-28 17:02   ` Bowers, AndrewX
2019-08-27 13:13 ` [Intel-wired-lan] [PATCH S28 3/9] ice: Check for DCB capability before initializing DCB Tony Nguyen
2019-08-28 17:03   ` Bowers, AndrewX
2019-08-27 13:13 ` [Intel-wired-lan] [PATCH S28 4/9] ice: Report VF link status with opcode to get resources Tony Nguyen
2019-08-28 17:03   ` Bowers, AndrewX
2019-08-27 13:13 ` [Intel-wired-lan] [PATCH S28 5/9] ice: update tx context struct Tony Nguyen
2019-08-28 17:04   ` Bowers, AndrewX
2019-08-27 13:13 ` [Intel-wired-lan] [PATCH S28 6/9] ice: Allow for delayed LLDP MIB change registration Tony Nguyen
2019-08-28 17:04   ` Bowers, AndrewX
2019-08-27 13:13 ` [Intel-wired-lan] [PATCH S28 7/9] ice: Minor refactor in queue management Tony Nguyen
2019-08-28 17:05   ` Bowers, AndrewX
2019-08-27 13:13 ` Tony Nguyen [this message]
2019-08-28 17:05   ` [Intel-wired-lan] [PATCH S28 8/9] ice: change default number of receive descriptors Bowers, AndrewX
2019-08-27 13:13 ` [Intel-wired-lan] [PATCH S28 9/9] ice: Rework around device/function capabilities Tony Nguyen
2019-08-28 17:05   ` Bowers, AndrewX
2019-08-28 17:02 ` [Intel-wired-lan] [PATCH S28 1/9] ice: Reliably reset VFs Bowers, AndrewX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190827131354.12703-8-anthony.l.nguyen@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox