From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Date: Sat, 12 Oct 2019 11:08:56 -0700 Subject: [Intel-wired-lan] [net-next v3 2/7] net: reject PTP periodic output requests with unsupported flags In-Reply-To: <20190926181109.4871-3-jacob.e.keller@intel.com> References: <20190926181109.4871-1-jacob.e.keller@intel.com> <20190926181109.4871-3-jacob.e.keller@intel.com> Message-ID: <20191012180856.GC3165@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: On Thu, Sep 26, 2019 at 11:11:04AM -0700, Jacob Keller wrote: > Commit 823eb2a3c4c7 ("PTP: add support for one-shot output") introduced > a new flag for the PTP periodic output request ioctl. This flag is not > currently supported by any driver. > > Fix all drivers which implement the periodic output request ioctl to > explicitly reject any request with flags they do not understand. This > ensures that the driver does not accidentally misinterpret the > PTP_PEROUT_ONE_SHOT flag, or any new flag introduced in the future. > > This is important for forward compatibility: if a new flag is > introduced, the driver should reject requests to enable the flag until > the driver has actually been modified to support the flag in question. > > Cc: Richard Cochran > Cc: Felipe Balbi > Cc: David S. Miller > Cc: Christopher Hall > Signed-off-by: Jacob Keller Reviewed-by: Richard Cochran