From: Jesper Dangaard Brouer <brouer@redhat.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH RFC v2 26/33] i40e: add XDP frame size to driver
Date: Tue, 14 Apr 2020 12:16:33 +0200 [thread overview]
Message-ID: <20200414121633.0461ece4@carbon> (raw)
In-Reply-To: <20200408.144845.783523592365109446.davem@davemloft.net>
On Wed, 08 Apr 2020 14:48:45 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Jesper Dangaard Brouer <brouer@redhat.com>
> Date: Wed, 08 Apr 2020 13:52:46 +0200
>
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> > index b8496037ef7f..1fb6b1004dcb 100644
> > --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> > +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> > @@ -1507,6 +1507,23 @@ static inline unsigned int i40e_rx_offset(struct i40e_ring *rx_ring)
> > return ring_uses_build_skb(rx_ring) ? I40E_SKB_PAD : 0;
> > }
> >
> > +static inline unsigned int i40e_rx_frame_truesize(struct i40e_ring *rx_ring,
> > + unsigned int size)
>
> Please don't use inline in foo.c files. I noticed you properly elided this in
> the ice changes so I wonder why it showed up here :-)
Yes, I know I should not do this. It got here by copy-paste accident,
as I first had ixgbe function in a header file, and later I decided to
move this into the ixgbe C-file, but I had already copy-pasted this
into i40e driver ;-)
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2020-04-14 10:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-08 11:50 [Intel-wired-lan] [PATCH RFC v2 00/33] XDP extend with knowledge of frame size Jesper Dangaard Brouer
2020-04-08 11:52 ` [Intel-wired-lan] [PATCH RFC v2 24/33] ixgbe: add XDP frame size to driver Jesper Dangaard Brouer
2020-04-08 11:52 ` [Intel-wired-lan] [PATCH RFC v2 25/33] ixgbevf: add XDP frame size to VF driver Jesper Dangaard Brouer
2020-04-08 11:52 ` [Intel-wired-lan] [PATCH RFC v2 26/33] i40e: add XDP frame size to driver Jesper Dangaard Brouer
2020-04-08 21:48 ` David Miller
2020-04-14 10:16 ` Jesper Dangaard Brouer [this message]
2020-04-08 11:52 ` [Intel-wired-lan] [PATCH RFC v2 27/33] ice: " Jesper Dangaard Brouer
2020-04-08 11:52 ` [Intel-wired-lan] [PATCH RFC v2 28/33] xdp: for Intel AF_XDP drivers add XDP frame_sz Jesper Dangaard Brouer
2020-04-08 17:31 ` =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2020-04-09 9:33 ` Maxim Mikityanskiy
2020-04-08 16:55 ` [Intel-wired-lan] [PATCH RFC v2 00/33] XDP extend with knowledge of frame size Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414121633.0461ece4@carbon \
--to=brouer@redhat.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox