From: Paul Menzel <pmenzel@molgen.mpg.de>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 2/2] ethernet: igb: e1000_phy: Check for ops.force_speed_duplex existence
Date: Tue, 3 Nov 2020 00:13:07 +0100 [thread overview]
Message-ID: <20201102231307.13021-3-pmenzel@molgen.mpg.de> (raw)
In-Reply-To: <20201102231307.13021-1-pmenzel@molgen.mpg.de>
From: Jeffrey Townsend <jeffrey.townsend@bigswitch.com>
The ops field might no be defined, so add a check.
The patch is taken from Open Network Linux (ONL), and it was added there
as part of the patch
packages/base/any/kernels/3.16+deb8/patches/driver-support-intel-igb-bcm5461X-phy.patch
in ONL commit f32316c63c (Support the BCM54616 and BCM5461S.) [1]. Part
of this commit was already upstreamed in Linux commit eeb0149660 (igb:
support BCM54616 PHY) in 2017.
I applied the forward-ported
packages/base/any/kernels/5.4-lts/patches/0002-driver-support-intel-igb-bcm5461S-phy.patch
added in ONL commit 5ace6bcdb3 (Add 5.4 LTS kernel build.) [2].
[1]: https://github.com/opencomputeproject/OpenNetworkLinux/commit/f32316c63ce3a64de125b7429115c6d45e942bd1
[2]: https://github.com/opencomputeproject/OpenNetworkLinux/commit/5ace6bcdb37cb8065dcd1d4404b3dcb6424f6331
Cc: Jeffrey Townsend <jeffrey.townsend@bigswitch.com>
Cc: John W Linville <linville@tuxdriver.com>
Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
drivers/net/ethernet/intel/igb/e1000_phy.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c
index 4e0b4ba09a00..4151e55a6d2a 100644
--- a/drivers/net/ethernet/intel/igb/e1000_phy.c
+++ b/drivers/net/ethernet/intel/igb/e1000_phy.c
@@ -1107,11 +1107,13 @@ s32 igb_setup_copper_link(struct e1000_hw *hw)
/* PHY will be set to 10H, 10F, 100H or 100F
* depending on user settings.
*/
- hw_dbg("Forcing Speed and Duplex\n");
- ret_val = hw->phy.ops.force_speed_duplex(hw);
- if (ret_val) {
- hw_dbg("Error Forcing Speed and Duplex\n");
- goto out;
+ if (hw->phy.ops.force_speed_duplex) {
+ hw_dbg("Forcing Speed and Duplex\n");
+ ret_val = hw->phy.ops.force_speed_duplex(hw);
+ if (ret_val) {
+ hw_dbg("Error Forcing Speed and Duplex\n");
+ goto out;
+ }
}
}
--
2.29.1
next prev parent reply other threads:[~2020-11-02 23:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 23:13 [Intel-wired-lan] [PATCH 0/2] Upstream ONL patch for PHY BCM5461S Paul Menzel
2020-11-02 23:13 ` [Intel-wired-lan] [PATCH 1/2] ethernet: igb: Support " Paul Menzel
2020-11-02 23:24 ` Paul Menzel
2020-11-03 1:15 ` Florian Fainelli
2020-11-02 23:13 ` Paul Menzel [this message]
2020-11-03 0:19 ` [Intel-wired-lan] [PATCH 2/2] ethernet: igb: e1000_phy: Check for ops.force_speed_duplex existence Jakub Kicinski
2020-11-03 7:35 ` Paul Menzel
2020-11-03 18:39 ` Jakub Kicinski
2021-01-05 17:16 ` Paul Menzel
2021-01-05 17:25 ` Greg KH
2021-01-19 6:55 ` Paul Menzel
2021-01-19 17:05 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102231307.13021-3-pmenzel@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox