From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v4 7/9] igc: Add initial XDP support
Date: Thu, 12 Nov 2020 14:18:54 -0800 [thread overview]
Message-ID: <20201112141854.00001197@intel.com> (raw)
In-Reply-To: <160521830157.29792.4388568942163519947@ngilbert-mobl1.amr.corp.intel.com>
Andre Guedes wrote:
> Quoting Neftin, Sasha (2020-11-12 01:13:27)
> > > +#define IGC_XDP_PASS 0
> > > +#define IGC_XDP_CONSUMED BIT(0)
> > > +
> > Hello Andre, please, move these defines to igc_defines.h to bottom the
> > file under /* XDP defines */ comment.
>
> Hi Sasha, looking at the macros defined in igc_defines.h, they seem to be
> hardware-related (registers, fields, masks, etc) which is not the case of
> the XDP macros defined here. In addition to that, note that these macros
> are used only in igc_main.c so maybe it makes sense to leave them here?
FWIW, I agree with Andre here, I'd just leave them in the igc_main.c
file.
next prev parent reply other threads:[~2020-11-12 22:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 3:12 [Intel-wired-lan] [PATCH v4 0/9] igc: Add XDP support Andre Guedes
2020-11-04 3:12 ` [Intel-wired-lan] [PATCH v4 1/9] igc: Fix igc_ptp_rx_pktstamp() Andre Guedes
2020-11-04 3:12 ` [Intel-wired-lan] [PATCH v4 2/9] igc: Remove unused argument from igc_tx_cmd_type() Andre Guedes
2020-11-04 3:12 ` [Intel-wired-lan] [PATCH v4 3/9] igc: Introduce igc_rx_buffer_flip() helper Andre Guedes
2020-11-04 3:12 ` [Intel-wired-lan] [PATCH v4 4/9] igc: Introduce igc_get_rx_frame_truesize() helper Andre Guedes
2020-11-04 3:12 ` [Intel-wired-lan] [PATCH v4 5/9] igc: Refactor rx timestamp handling Andre Guedes
2020-11-04 3:12 ` [Intel-wired-lan] [PATCH v4 6/9] igc: Add set/clear large buffer helpers Andre Guedes
2020-11-04 3:12 ` [Intel-wired-lan] [PATCH v4 7/9] igc: Add initial XDP support Andre Guedes
2020-11-12 9:13 ` Neftin, Sasha
2020-11-12 21:58 ` Andre Guedes
2020-11-12 22:18 ` Jesse Brandeburg [this message]
2020-11-04 3:12 ` [Intel-wired-lan] [PATCH v4 8/9] igc: Add support for XDP_TX action Andre Guedes
2020-11-04 3:12 ` [Intel-wired-lan] [PATCH v4 9/9] igc: Add support for XDP_REDIRECT action Andre Guedes
2020-11-12 9:03 ` Neftin, Sasha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201112141854.00001197@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox