From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next 6/8] ice: remove redundant checks in ice_change_mtu
Date: Fri, 11 Dec 2020 17:49:54 +0100 [thread overview]
Message-ID: <20201211164956.59628-7-maciej.fijalkowski@intel.com> (raw)
In-Reply-To: <20201211164956.59628-1-maciej.fijalkowski@intel.com>
dev_validate_mtu checks that mtu value specified by user is not less
than min mtu and not greater than max allowed mtu. It is being done
before calling the ndo_change_mtu exposed by driver, so remove these
redundant checks in ice_change_mtu.
Signed-off-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
drivers/net/ethernet/intel/ice/ice_main.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 2dea4d0e9415..476e20af7309 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -6126,15 +6126,6 @@ static int ice_change_mtu(struct net_device *netdev, int new_mtu)
}
}
- if (new_mtu < (int)netdev->min_mtu) {
- netdev_err(netdev, "new MTU invalid. min_mtu is %d\n",
- netdev->min_mtu);
- return -EINVAL;
- } else if (new_mtu > (int)netdev->max_mtu) {
- netdev_err(netdev, "new MTU invalid. max_mtu is %d\n",
- netdev->min_mtu);
- return -EINVAL;
- }
/* if a reset is in progress, wait for some time for it to complete */
do {
if (ice_is_reset_in_progress(pf->state)) {
--
2.20.1
next prev parent reply other threads:[~2020-12-11 16:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 16:49 [Intel-wired-lan] [PATCH net-next 0/8] i40e/ice cleanups Maciej Fijalkowski
2020-12-11 16:49 ` [Intel-wired-lan] [PATCH net-next 1/8] i40e: drop redundant check when setting xdp prog Maciej Fijalkowski
2020-12-11 16:49 ` [Intel-wired-lan] [PATCH net-next 2/8] i40e: drop misleading function comments Maciej Fijalkowski
2020-12-11 16:49 ` [Intel-wired-lan] [PATCH net-next 3/8] i40e: adjust i40e_is_non_eop Maciej Fijalkowski
2020-12-11 16:49 ` [Intel-wired-lan] [PATCH net-next 4/8] ice: simplify ice_run_xdp Maciej Fijalkowski
2020-12-11 16:49 ` [Intel-wired-lan] [PATCH net-next 5/8] ice: move skb pointer from rx_buf to rx_ring Maciej Fijalkowski
2020-12-12 4:23 ` Jakub Kicinski
2020-12-14 15:07 ` Maciej Fijalkowski
2020-12-11 16:49 ` Maciej Fijalkowski [this message]
2020-12-11 16:49 ` [Intel-wired-lan] [PATCH net-next 7/8] ice: skip NULL check against XDP prog in ZC path Maciej Fijalkowski
2020-12-11 16:49 ` [Intel-wired-lan] [PATCH net-next 8/8] i40e, xsk: Simplify the do-while allocation loop Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211164956.59628-7-maciej.fijalkowski@intel.com \
--to=maciej.fijalkowski@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox