From: Vladimir Oltean <olteanv@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [RFC PATCH v2 net-next 12/12] net: remove obsolete comments about ndo_get_stats64 context from eth drivers
Date: Tue, 5 Jan 2021 20:59:02 +0200 [thread overview]
Message-ID: <20210105185902.3922928-13-olteanv@gmail.com> (raw)
In-Reply-To: <20210105185902.3922928-1-olteanv@gmail.com>
From: Vladimir Oltean <vladimir.oltean@nxp.com>
Now that we have a good summary in Documentation/networking/netdevices.rst,
these comments serve no purpose and are actually distracting/confusing.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
drivers/net/ethernet/cisco/enic/enic_main.c | 1 -
drivers/net/ethernet/nvidia/forcedeth.c | 2 --
drivers/net/ethernet/sfc/efx_common.c | 1 -
drivers/net/ethernet/sfc/falcon/efx.c | 1 -
4 files changed, 5 deletions(-)
diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
index fb269d587b74..7425f94f9091 100644
--- a/drivers/net/ethernet/cisco/enic/enic_main.c
+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
@@ -870,7 +870,6 @@ static netdev_tx_t enic_hard_start_xmit(struct sk_buff *skb,
return NETDEV_TX_OK;
}
-/* dev_base_lock rwlock held, nominally process context */
static void enic_get_stats(struct net_device *netdev,
struct rtnl_link_stats64 *net_stats)
{
diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
index 8724d6a9ed02..8fa254dc64e9 100644
--- a/drivers/net/ethernet/nvidia/forcedeth.c
+++ b/drivers/net/ethernet/nvidia/forcedeth.c
@@ -1761,8 +1761,6 @@ static void nv_get_stats(int cpu, struct fe_priv *np,
/*
* nv_get_stats64: dev->ndo_get_stats64 function
* Get latest stats value from the nic.
- * Called with read_lock(&dev_base_lock) held for read -
- * only synchronized against unregister_netdevice.
*/
static void
nv_get_stats64(struct net_device *dev, struct rtnl_link_stats64 *storage)
diff --git a/drivers/net/ethernet/sfc/efx_common.c b/drivers/net/ethernet/sfc/efx_common.c
index de797e1ac5a9..4d8047b35fb2 100644
--- a/drivers/net/ethernet/sfc/efx_common.c
+++ b/drivers/net/ethernet/sfc/efx_common.c
@@ -596,7 +596,6 @@ void efx_stop_all(struct efx_nic *efx)
efx_stop_datapath(efx);
}
-/* Context: process, dev_base_lock or RTNL held, non-blocking. */
void efx_net_stats(struct net_device *net_dev, struct rtnl_link_stats64 *stats)
{
struct efx_nic *efx = netdev_priv(net_dev);
diff --git a/drivers/net/ethernet/sfc/falcon/efx.c b/drivers/net/ethernet/sfc/falcon/efx.c
index f8979991970e..6db2b6583dec 100644
--- a/drivers/net/ethernet/sfc/falcon/efx.c
+++ b/drivers/net/ethernet/sfc/falcon/efx.c
@@ -2096,7 +2096,6 @@ int ef4_net_stop(struct net_device *net_dev)
return 0;
}
-/* Context: process, dev_base_lock or RTNL held, non-blocking. */
static void ef4_net_stats(struct net_device *net_dev,
struct rtnl_link_stats64 *stats)
{
--
2.25.1
next prev parent reply other threads:[~2021-01-05 18:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-05 18:58 [Intel-wired-lan] [RFC PATCH v2 net-next 00/12] Make .ndo_get_stats64 sleepable Vladimir Oltean
2021-01-05 18:58 ` [Intel-wired-lan] [RFC PATCH v2 net-next 01/12] net: mark dev_base_lock for deprecation Vladimir Oltean
2021-01-05 18:58 ` [Intel-wired-lan] [RFC PATCH v2 net-next 02/12] net: introduce a mutex for the netns interface lists Vladimir Oltean
2021-01-05 18:58 ` [Intel-wired-lan] [RFC PATCH v2 net-next 03/12] net: procfs: hold netif_lists_lock when retrieving device statistics Vladimir Oltean
2021-01-05 18:58 ` [Intel-wired-lan] [RFC PATCH v2 net-next 04/12] net: sysfs: don't hold dev_base_lock while " Vladimir Oltean
2021-01-05 18:58 ` [Intel-wired-lan] [RFC PATCH v2 net-next 05/12] s390/appldata_net_sum: hold the netdev lists lock when " Vladimir Oltean
2021-01-05 18:58 ` [Intel-wired-lan] [RFC PATCH v2 net-next 06/12] parisc/led: reindent the code that gathers " Vladimir Oltean
2021-01-05 18:58 ` [Intel-wired-lan] [RFC PATCH v2 net-next 07/12] parisc/led: hold the netdev lists lock when retrieving " Vladimir Oltean
2021-01-05 18:58 ` [Intel-wired-lan] [RFC PATCH v2 net-next 08/12] net: make dev_get_stats return void Vladimir Oltean
2021-01-05 18:58 ` [Intel-wired-lan] [RFC PATCH v2 net-next 09/12] net: net_failover: ensure .ndo_get_stats64 can sleep Vladimir Oltean
2021-01-05 18:59 ` [Intel-wired-lan] [RFC PATCH v2 net-next 10/12] net: bonding: " Vladimir Oltean
2021-01-05 18:59 ` [Intel-wired-lan] [RFC PATCH v2 net-next 11/12] net: mark ndo_get_stats64 as being able to sleep Vladimir Oltean
2021-01-05 18:59 ` Vladimir Oltean [this message]
2021-01-06 13:45 ` [Intel-wired-lan] [RFC PATCH v2 net-next 00/12] Make .ndo_get_stats64 sleepable Vladimir Oltean
2021-01-09 1:26 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210105185902.3922928-13-olteanv@gmail.com \
--to=olteanv@gmail.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox