Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vedang Patel <vedang.patel@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net v1] igc: Don't clear the large buffer bit before memory release
Date: Thu,  7 Jan 2021 10:56:54 -0800	[thread overview]
Message-ID: <20210107185654.1826-1-vedang.patel@intel.com> (raw)

When XDP is enabled, it uses large buffers to accomodate headroom and
tailroom required by XDP infrastructure. But, it clears the large buffer
bit before unmapping the buffer.

dma_unmap_page_attrs() (called by igc_clean_rx_ring_page_shared()) needs
size of the buffer to unmap. If the large buffer bit is cleared before
calling igc_clean_rx_ring_page_shared(), all of the memory won't be
unmapped.

Fixes: 2e739318416b ("igc: Add initial XDP support")

Signed-off-by: Vedang Patel <vedang.patel@intel.com>
---
 drivers/net/ethernet/intel/igc/igc_main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index 0bcdf05d03f0..b96b745fdb65 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -418,13 +418,13 @@ static void igc_clean_rx_ring_xsk_pool(struct igc_ring *ring)
  */
 static void igc_clean_rx_ring(struct igc_ring *ring)
 {
-	clear_ring_uses_large_buffer(ring);
-
 	if (ring->xsk_pool)
 		igc_clean_rx_ring_xsk_pool(ring);
 	else
 		igc_clean_rx_ring_page_shared(ring);
 
+	clear_ring_uses_large_buffer(ring);
+
 	ring->next_to_alloc = 0;
 	ring->next_to_clean = 0;
 	ring->next_to_use = 0;
-- 
2.17.1


             reply	other threads:[~2021-01-07 18:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-07 18:56 Vedang Patel [this message]
2021-01-07 19:10 ` [Intel-wired-lan] [PATCH net v1] igc: Don't clear the large buffer bit before memory release Maciej Fijalkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210107185654.1826-1-vedang.patel@intel.com \
    --to=vedang.patel@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox