From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v1 1/2] net: core: count drops from GRO
Date: Fri, 8 Jan 2021 10:23:22 -0800 [thread overview]
Message-ID: <20210108102322.00004b93@intel.com> (raw)
In-Reply-To: <5badc441-6de9-54cf-2b72-d67572cbb105@intel.com>
Jacob Keller wrote:
> > case GRO_DROP:
> > + atomic_long_inc(&skb->dev->rx_dropped);
> > kfree_skb(skb);
> > break;
>
> Would it makes sense to have this be a different stat? or is it really
> basically the same as the existing rx_dropped, so treating it
> differently wouldn't make much sense..
not sure, was hoping to get feedback here. More later in the thread...
next prev parent reply other threads:[~2021-01-08 18:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-06 21:55 [Intel-wired-lan] [PATCH net-next v1 0/2] GRO drop accounting Jesse Brandeburg
2021-01-06 21:55 ` [Intel-wired-lan] [PATCH net-next v1 1/2] net: core: count drops from GRO Jesse Brandeburg
2021-01-07 18:47 ` Jacob Keller
2021-01-07 21:15 ` Alexander Duyck
2021-01-08 18:23 ` Jesse Brandeburg [this message]
2021-01-08 0:50 ` Shannon Nelson
2021-01-08 18:26 ` Jesse Brandeburg
2021-01-08 19:21 ` Shannon Nelson
2021-01-08 20:26 ` Saeed Mahameed
2021-01-08 22:17 ` Eric Dumazet
2021-01-14 13:53 ` Jamal Hadi Salim
2021-01-08 9:25 ` Eric Dumazet
2021-01-08 18:35 ` Jesse Brandeburg
2021-01-08 18:45 ` Eric Dumazet
2021-01-09 0:54 ` Jacob Keller
2021-01-06 21:55 ` [Intel-wired-lan] [PATCH net-next v1 2/2] ice: remove GRO drop accounting Jesse Brandeburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210108102322.00004b93@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox