From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net v3] i40e: Fix for link-flapping
Date: Tue, 12 Jan 2021 19:41:07 -0800 [thread overview]
Message-ID: <20210112194107.00002d0b@intel.com> (raw)
In-Reply-To: <20210112171431.457524-1-arkadiusz.kubalewski@intel.com>
Arkadiusz Kubalewski wrote:
> VF queues were not brought up when PF was brought up after being downed
> if the VF driver disabled VFs queues during PF down. This could happen
> in some older or external VF driver implementations.
> The problem was that PF driver used vf->queues_enabled as a condition
> to decide what link-state it would send out which caused the issue.
> Remove the check for vf->queues_enabled in the VF link notify. Now VF
> will always be notified of the current link status. Also remove
> the queues_enabled member from i40e_vf structure as it is not used
> anymore. Also refactor repeated link state reporting code into a
> separate helper function i40e_set_vf_link_state().
> Otherwise VNF implementation was broken and caused a link flap.
>
> v2: improve commit message
> v3: net tree target
For future patches, please put vX: messages after a ---
which will allow git am to strip the vX: comments. You can optionally
put the vX: messages in the same section as the diffstat info.
>
> Fixes: 2ad1274fa35a ("i40e: don't report link up for a VF who hasn't
> enabled")
You probably don't need to wrap the Fixes line, but it probably
doesn't hurt either.
> Signed-off-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
> Signed-off-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
The patch sender's signoff should be last (think chronological order
starting with oldest at the top)
prev parent reply other threads:[~2021-01-13 3:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 17:14 [Intel-wired-lan] [PATCH net v3] i40e: Fix for link-flapping Arkadiusz Kubalewski
2021-01-13 3:41 ` Jesse Brandeburg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210112194107.00002d0b@intel.com \
--to=jesse.brandeburg@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox