From: Vedang Patel <vedang.patel@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v3 0/9] igc: Add support for AF_XDP zero-copy
Date: Mon, 8 Feb 2021 18:42:34 -0800 [thread overview]
Message-ID: <20210209024243.23406-1-vedang.patel@intel.com> (raw)
Hi all,
This is the third version of this series which adds AF_XDP zero-copy support
to igc driver.
The main changes from v2 are:
- In igc_clean_rx_ring(), clear large buffer bit after calling
dma_unmap_page_attrs(). dma_unmap_page_attrs() needs the buffer
size in order to unmap the page.
- In igc_clean_rx_irq_zc(), the Rx hardware timestamp is needed if
the BPF program returns XDP_PASS and the packet needs to be passed
to the network stack.
Known issues:
When an XDP application is running in Tx-Only mode with Zero-Copy
enabled, it is not expected to add the frames to the fill-queue. I have
noticed the following two issues in this scenario:
- If XDP_USE_NEED_WAKEUP flag is not set by application, igc_poll()
will go into infinite loop because the buffer allocation resulting
in igc_clean_rx_irq_zc() indicating that all work is not done and NAPI
should keep polling. This does not occur if XDP_USE_NEED_WAKEUP
flag is set.
- Since there are no buffers allocated by userspace for the fill
queue, there is no memory allocated for the NIC to copy the data
to. If the packet received is destined to the hardware queue where
XDP application is running, no packets are received even on other
queues.
Both these issues can be mitigated by adding a few frames to the
fill queue. The second issue can also be mitigated by making sure no
packets are being received on the hardware queue where Rx is running.
v2 is here:
https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20201223203705.78705-1-andre.guedes at intel.com/
v1 is here:
https://patchwork.ozlabs.org/project/intel-wired-lan/cover/20201217202415.77891-1-andre.guedes at intel.com/
Thanks,
Vedang
Andre Guedes (9):
igc: Move igc_xdp_is_enabled()
igc: Refactor igc_xdp_run_prog()
igc: Refactor igc_clean_rx_ring()
igc: Refactor XDP rxq info registration
igc: Introduce tx/rx stats helpers
igc: Introduce igc_unmap_tx_buffer() helper
igc: Replace IGC_TX_FLAGS_XDP flag by an enum
igc: Enable RX via AF_XDP zero-copy
igc: Enable TX via AF_XDP zero-copy
drivers/net/ethernet/intel/igc/igc.h | 33 +-
drivers/net/ethernet/intel/igc/igc_base.h | 2 +
drivers/net/ethernet/intel/igc/igc_main.c | 651 ++++++++++++++++++----
drivers/net/ethernet/intel/igc/igc_xdp.c | 107 +++-
drivers/net/ethernet/intel/igc/igc_xdp.h | 8 +-
5 files changed, 674 insertions(+), 127 deletions(-)
--
2.17.1
next reply other threads:[~2021-02-09 2:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 2:42 Vedang Patel [this message]
2021-02-09 2:42 ` [Intel-wired-lan] [PATCH net-next v3 1/9] igc: Move igc_xdp_is_enabled() Vedang Patel
2021-02-09 2:42 ` [Intel-wired-lan] [PATCH net-next v3 2/9] igc: Refactor igc_xdp_run_prog() Vedang Patel
2021-02-11 0:31 ` Maciej Fijalkowski
2021-02-09 2:42 ` [Intel-wired-lan] [PATCH net-next v3 3/9] igc: Refactor igc_clean_rx_ring() Vedang Patel
2021-02-09 2:42 ` [Intel-wired-lan] [PATCH net-next v3 4/9] igc: Refactor XDP rxq info registration Vedang Patel
2021-02-09 2:42 ` [Intel-wired-lan] [PATCH net-next v3 5/9] igc: Introduce tx/rx stats helpers Vedang Patel
2021-02-09 2:42 ` [Intel-wired-lan] [PATCH net-next v3 6/9] igc: Introduce igc_unmap_tx_buffer() helper Vedang Patel
2021-02-09 2:42 ` [Intel-wired-lan] [PATCH net-next v3 7/9] igc: Replace IGC_TX_FLAGS_XDP flag by an enum Vedang Patel
2021-02-09 2:42 ` [Intel-wired-lan] [PATCH net-next v3 8/9] igc: Enable RX via AF_XDP zero-copy Vedang Patel
2021-02-11 0:55 ` Maciej Fijalkowski
2021-02-09 2:42 ` [Intel-wired-lan] [PATCH net-next v3 9/9] igc: Enable TX " Vedang Patel
2021-02-11 1:09 ` Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209024243.23406-1-vedang.patel@intel.com \
--to=vedang.patel@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox