From: Jithu Joseph <jithu.joseph@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v4 3/9] igc: Refactor igc_clean_rx_ring()
Date: Mon, 22 Feb 2021 01:09:30 -0800 [thread overview]
Message-ID: <20210222090936.6768-4-jithu.joseph@intel.com> (raw)
In-Reply-To: <20210222090936.6768-1-jithu.joseph@intel.com>
From: Andre Guedes <andre.guedes@intel.com>
Refactor igc_clean_rx_ring() helper, preparing the code for AF_XDP
zero-copy support which is added by upcoming patches.
The refactor consists of encapsulating page-shared specific code into
its own helper, leaving common code that will be shared by both
page-shared and xsk pool in igc_clean_rx_ring().
Signed-off-by: Andre Guedes <andre.guedes@intel.com>
Signed-off-by: Vedang Patel <vedang.patel@intel.com>
Signed-off-by: Jithu Joseph <jithu.joseph@intel.com>
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
---
drivers/net/ethernet/intel/igc/igc_main.c | 23 ++++++++++++++---------
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c
index d9d60c6c6726..bc086d2f738b 100644
--- a/drivers/net/ethernet/intel/igc/igc_main.c
+++ b/drivers/net/ethernet/intel/igc/igc_main.c
@@ -346,11 +346,7 @@ static int igc_setup_all_tx_resources(struct igc_adapter *adapter)
return err;
}
-/**
- * igc_clean_rx_ring - Free Rx Buffers per Queue
- * @rx_ring: ring to free buffers from
- */
-static void igc_clean_rx_ring(struct igc_ring *rx_ring)
+static void igc_clean_rx_ring_page_shared(struct igc_ring *rx_ring)
{
u16 i = rx_ring->next_to_clean;
@@ -383,12 +379,21 @@ static void igc_clean_rx_ring(struct igc_ring *rx_ring)
if (i == rx_ring->count)
i = 0;
}
+}
+
+/**
+ * igc_clean_rx_ring - Free Rx Buffers per Queue
+ * @ring: ring to free buffers from
+ */
+static void igc_clean_rx_ring(struct igc_ring *ring)
+{
+ igc_clean_rx_ring_page_shared(ring);
- clear_ring_uses_large_buffer(rx_ring);
+ clear_ring_uses_large_buffer(ring);
- rx_ring->next_to_alloc = 0;
- rx_ring->next_to_clean = 0;
- rx_ring->next_to_use = 0;
+ ring->next_to_alloc = 0;
+ ring->next_to_clean = 0;
+ ring->next_to_use = 0;
}
/**
--
2.17.1
next prev parent reply other threads:[~2021-02-22 9:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 9:09 [Intel-wired-lan] [PATCH v4 0/9] igc: Add support for AF_XDP zero-copy Jithu Joseph
2021-02-22 9:09 ` [Intel-wired-lan] [PATCH v4 1/9] igc: Move igc_xdp_is_enabled() Jithu Joseph
2021-02-22 9:09 ` [Intel-wired-lan] [PATCH v4 2/9] igc: Refactor __igc_xdp_run_prog() Jithu Joseph
2021-02-22 9:09 ` Jithu Joseph [this message]
2021-02-22 9:09 ` [Intel-wired-lan] [PATCH v4 4/9] igc: Refactor XDP rxq info registration Jithu Joseph
2021-02-22 9:32 ` =?unknown-8bit?q?Bj=C3=B6rn_T=C3=B6pel?=
2021-02-26 0:15 ` Joseph, Jithu
2021-02-22 9:09 ` [Intel-wired-lan] [PATCH v4 5/9] igc: Introduce TX/RX stats helpers Jithu Joseph
2021-02-22 9:09 ` [Intel-wired-lan] [PATCH v4 6/9] igc: Introduce igc_unmap_tx_buffer() helper Jithu Joseph
2021-02-22 9:09 ` [Intel-wired-lan] [PATCH v4 7/9] igc: Replace IGC_TX_FLAGS_XDP flag by an enum Jithu Joseph
2021-02-22 9:09 ` [Intel-wired-lan] [PATCH v4 8/9] igc: Enable RX via AF_XDP zero-copy Jithu Joseph
2021-02-22 9:09 ` [Intel-wired-lan] [PATCH v4 9/9] igc: Enable TX " Jithu Joseph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222090936.6768-4-jithu.joseph@intel.com \
--to=jithu.joseph@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox