Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Keller <jacob.e.keller@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next 3/6] ice: remove return value comment for ice_reset_all_vfs
Date: Mon, 11 Apr 2022 16:29:04 -0700	[thread overview]
Message-ID: <20220411232907.1022602-4-jacob.e.keller@intel.com> (raw)
In-Reply-To: <20220411232907.1022602-1-jacob.e.keller@intel.com>

Since commit fe99d1c06c16 ("ice: make ice_reset_all_vfs void"), the
ice_reset_all_vfs function has not returned anything. The function
comment still indicated it did. Fix this.

While here, also add a line to clarify the function resets all VFs at
once in response to hardware resets such as a PF reset.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
---
 drivers/net/ethernet/intel/ice/ice_vf_lib.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/ice/ice_vf_lib.c b/drivers/net/ethernet/intel/ice/ice_vf_lib.c
index aefd66a4db80..24cf6a5b49fe 100644
--- a/drivers/net/ethernet/intel/ice/ice_vf_lib.c
+++ b/drivers/net/ethernet/intel/ice/ice_vf_lib.c
@@ -359,12 +359,12 @@ ice_vf_clear_vsi_promisc(struct ice_vf *vf, struct ice_vsi *vsi, u8 promisc_m)
  * ice_reset_all_vfs - reset all allocated VFs in one go
  * @pf: pointer to the PF structure
  *
+ * Reset all VFs at once, in response to a PF or other device reset.
+ *
  * First, tell the hardware to reset each VF, then do all the waiting in one
  * chunk, and finally finish restoring each VF after the wait. This is useful
  * during PF routines which need to reset all VFs, as otherwise it must perform
  * these resets in a serialized fashion.
- *
- * Returns true if any VFs were reset, and false otherwise.
  */
 void ice_reset_all_vfs(struct ice_pf *pf)
 {
-- 
2.35.1.456.ga9c7032d4631


  parent reply	other threads:[~2022-04-11 23:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-11 23:29 [Intel-wired-lan] [PATCH net-next 0/6] minor cleanups for ice virtualization Jacob Keller
2022-04-11 23:29 ` [Intel-wired-lan] [PATCH net-next 1/6] ice: add newline to dev_dbg in ice_vf_fdir_dump_info Jacob Keller
2022-04-12  5:10   ` Paul Menzel
2022-04-12 16:36     ` Keller, Jacob E
2022-04-11 23:29 ` [Intel-wired-lan] [PATCH net-next 2/6] ice: always check VF VSI pointer values Jacob Keller
2022-04-12  5:38   ` Paul Menzel
2022-04-12 17:35     ` Jacob Keller
2022-04-12 17:50       ` Paul Menzel
2022-04-18 22:58         ` Jacob Keller
2022-04-26  5:50   ` Jankowski, Konrad0
2022-04-11 23:29 ` Jacob Keller [this message]
2022-04-11 23:29 ` [Intel-wired-lan] [PATCH net-next 4/6] ice: fix wording in comment for ice_reset_vf Jacob Keller
2022-04-11 23:29 ` [Intel-wired-lan] [PATCH net-next 5/6] ice: add a function comment for ice_cfg_mac_antispoof Jacob Keller
2022-04-11 23:29 ` [Intel-wired-lan] [PATCH net-next 6/6] ice: remove period on argument description in ice_for_each_vf Jacob Keller
2022-04-12  5:44 ` [Intel-wired-lan] [PATCH net-next 0/6] minor cleanups for ice virtualization Paul Menzel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220411232907.1022602-4-jacob.e.keller@intel.com \
    --to=jacob.e.keller@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox