From: Jakub Kicinski <kuba@kernel.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v6 2/2] net: vxlan: Add extack support to vxlan_fdb_delete
Date: Mon, 9 May 2022 15:46:03 -0700 [thread overview]
Message-ID: <20220509154603.4a7b4243@kernel.org> (raw)
In-Reply-To: <ac4b6c650b6519cc56baa32ef20415460a5aa8ee.1651762830.git.eng.alaamohamedsoliman.am@gmail.com>
On Thu, 5 May 2022 17:09:58 +0200 Alaa Mohamed wrote:
> + NL_SET_ERR_MSG(extack,
> + "DST, VNI, ifindex and port are mutually exclusive with NH_ID");
This continuation line still does not align with the opening bracket.
Look here if your email client makes it hard to see:
https://lore.kernel.org/all/ac4b6c650b6519cc56baa32ef20415460a5aa8ee.1651762830.git.eng.alaamohamedsoliman.am at gmail.com/
Same story in patch 1:
> static int ocelot_port_fdb_del(struct ndmsg *ndm, struct nlattr *tb[],
> struct net_device *dev,
> - const unsigned char *addr, u16 vid)
> + const unsigned char *addr, u16 vid,
> + struct netlink_ext_ack *extack)
and here:
> static int vxlan_fdb_delete(struct ndmsg *ndm, struct nlattr *tb[],
> struct net_device *dev,
> - const unsigned char *addr, u16 vid)
> + const unsigned char *addr, u16 vid,
> + struct netlink_ext_ack *extack)
next prev parent reply other threads:[~2022-05-09 22:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 15:09 [Intel-wired-lan] [PATCH net-next v6 0/2] propagate extack to vxlan_fdb_delete Alaa Mohamed
2022-05-05 15:09 ` [Intel-wired-lan] [PATCH net-next v6 1/2] rtnetlink: add extack support in fdb del handlers Alaa Mohamed
2022-05-05 15:09 ` [Intel-wired-lan] [PATCH net-next v6 2/2] net: vxlan: Add extack support to vxlan_fdb_delete Alaa Mohamed
2022-05-09 22:46 ` Jakub Kicinski [this message]
2022-05-12 8:39 ` Alaa Mohamed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220509154603.4a7b4243@kernel.org \
--to=kuba@kernel.org \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox