From: Piotr Skajewski <piotrx.skajewski@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v2 1/1] ixgbe: correct SDP0 check of SFP cage for X550
Date: Wed, 11 May 2022 10:32:15 +0200 [thread overview]
Message-ID: <20220511083215.9833-1-piotrx.skajewski@intel.com> (raw)
In-Reply-To: <20220425131758.4749-1-jeffd@silicom-usa.com>
Hi Jeff,
Our analysis (using 0x15c4) showed that every time the cage is empty SDP
indicates 0 and when cage is full it indicates 1. No matter what
transceiver we used, from those we have. The same happens even we don't
use the device which fall into crosstalk fix e.g 0x15c2.
When proposed patch was applied, the devices are no longer able to
negotiate speed. So basically this patch should not be accepted.
NACK
BR,
Piotr
next prev parent reply other threads:[~2022-05-11 8:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 20:51 [Intel-wired-lan] [PATCH 1/1] ixgbe: correct SDP0 check of SFP cage for X550 Jeff Daly
2022-04-22 22:52 ` Jakub Kicinski
2022-04-25 13:17 ` [Intel-wired-lan] [PATCH v2 " Jeff Daly
2022-05-11 8:32 ` Piotr Skajewski [this message]
2022-05-12 17:09 ` Tony Nguyen
2022-05-13 20:38 ` Jeff Daly
-- strict thread matches above, loose matches on Subject: below --
2022-05-10 11:21 Skajewski, PiotrX
2022-05-10 11:28 ` Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511083215.9833-1-piotrx.skajewski@intel.com \
--to=piotrx.skajewski@intel.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox