From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net-next v7 2/2] net: vxlan: Add extack support to vxlan_fdb_delete
Date: Thu, 12 May 2022 17:50:56 +0000 [thread overview]
Message-ID: <20220512175055.65ftcpkig3t3ttsq@skbuf> (raw)
In-Reply-To: <c6b41db9-78e7-e752-3945-29c70a3d8cb4@nvidia.com>
On Thu, May 12, 2022 at 10:17:13AM -0700, Roopa Prabhu wrote:
>
> On 5/12/22 09:47, Jakub Kicinski wrote:
> > On Thu, 12 May 2022 09:22:17 -0700 Roopa Prabhu wrote:
> > > On 5/12/22 02:55, Alaa Mohamed wrote:
> > > > This patch adds extack msg support to vxlan_fdb_delete and vxlan_fdb_parse.
> > > > extack is used to propagate meaningful error msgs to the user of vxlan
> > > > fdb netlink api
> > > >
> > > > Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> > Also the patches don't apply to net-next, again.
>
> that's probably because the patches were already applied. Ido just told me
> abt it also
>
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=5dd6da25255a9d64622c693b99d7668da939a980
>
> I have requested Alaa send an incremental fix (offline).
>
> thanks
>
Alaa, when you send the incremental fixup patch requested by Roopa,
could you please also:
- properly align the extack argument of the ocelot_port_fdb_del()
function
- properly align the extack argument of the vxlan_fdb_delete() function
- properly align the "DST, VNI, ifindex and port are mutually exclusive with NH_ID"
string to the open parenthesis of the NL_SET_ERR_MSG macro in vxlan_fdb_parse().
- make actual use of the extack in ice_fdb_add() and ice_fdb_del(), and
remove the __always_unused from ice_fdb_add().
Thank you.
next prev parent reply other threads:[~2022-05-12 17:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 9:55 [Intel-wired-lan] [PATCH net-next v7 0/2] propagate extack to vxlan_fdb_delete Alaa Mohamed
2022-05-12 9:55 ` [Intel-wired-lan] [PATCH net-next v7 1/2] rtnetlink: add extack support in fdb del handlers Alaa Mohamed
2022-05-12 9:55 ` [Intel-wired-lan] [PATCH net-next v7 2/2] net: vxlan: Add extack support to vxlan_fdb_delete Alaa Mohamed
2022-05-12 16:22 ` Roopa Prabhu
2022-05-12 16:47 ` Jakub Kicinski
2022-05-12 17:17 ` Roopa Prabhu
2022-05-12 17:50 ` Vladimir Oltean [this message]
2022-05-12 17:58 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512175055.65ftcpkig3t3ttsq@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox