Intel-Wired-Lan Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Lobakin <alexandr.lobakin@intel.com>
To: "Palczewski, Mateusz" <mateusz.palczewski@intel.com>
Cc: intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH net v2 0/3] iavf: Fix pending DMA allocations while released from device
Date: Tue, 28 Jun 2022 16:19:11 +0200	[thread overview]
Message-ID: <20220628141911.1403944-1-alexandr.lobakin@intel.com> (raw)
In-Reply-To: <20220628134308.706012-1-mateusz.palczewski@intel.com>

From: "Palczewski, Mateusz" <mateusz.palczewski@intel.com>
Date: Tue, 28 Jun 2022 15:43:08 +0200

First, please check your Git mail settings. You appear as
'"Palczewski, Mateusz"' in the 'From:' mail header, but at the same
time as 'Mateusz Palczewski' in Signed-off-bys. That's not how it
should look like, please pick one (preferably the one from SoBs) and
make sure it's configured properly everywhere.

> Fix multiple issues that can arise, when VF cannot configure ASQ/ARQ properly.
> Failing to do so can lead to driver hang, null ptr dereference and possible
> DMA allocations leak.
> 
> ---
>  v2: Add comment to make code more understandable
> ---
> 
> Przemyslaw Patynowski (3):
>   iavf: Fix reset error handling
>   iavf: Fix NULL pointer dereference in iavf_get_link_ksettings
>   iavf: Fix adminq error handling

Second, please check your Git mail settings again in regards to that
Git doesn't make a thread from your patch series, e.g. it doesn't
put correct 'In-Reply-To:' and 'References:' headers starting from
the second message. That breaks Patchwork, i.e. it won't be able to
test it as a series etc.

Please do a resend once you fix all of these.

> 
>  drivers/net/ethernet/intel/iavf/iavf_adminq.c  | 15 +++++++++++++--
>  drivers/net/ethernet/intel/iavf/iavf_ethtool.c |  6 ++++++
>  drivers/net/ethernet/intel/iavf/iavf_main.c    | 14 ++++++++++----
>  3 files changed, 29 insertions(+), 6 deletions(-)
> 
> -- 
> 2.27.0

Thanks,
Olek
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

      reply	other threads:[~2022-06-28 14:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-28 13:43 [Intel-wired-lan] [PATCH net v2 0/3] iavf: Fix pending DMA allocations while released from device Palczewski, Mateusz
2022-06-28 14:19 ` Alexander Lobakin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220628141911.1403944-1-alexandr.lobakin@intel.com \
    --to=alexandr.lobakin@intel.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=mateusz.palczewski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox