From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DB052C6FA90 for ; Tue, 20 Sep 2022 18:36:30 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 6209460F2F; Tue, 20 Sep 2022 18:36:30 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6209460F2F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1663698990; bh=hiRu3aYLxdUN+o24+aN7X+BhRomdrglfrdUWQMBemeQ=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=K883AnmoXeMlAimvuZKX2VVNzC4hcr4U3+euCH2kg1qwVLIccRspfjeM7/4sEPmFA sullolhkkdZLfrnl3VB0lyZnCY3lD7jPTrlGUSCzTPFoOg78Hywnp6LpAXNsGJxQ1l Y+luiypbMUO7o/38EcgVr+tpCYbo0kQYkY/fgwtMyqElWsdONUnfVgCEZsnXpK8RFk tXYetdViNrbHkyBqlhJNYSHyyArgWKUOLuzYj6Sffe0eP1/+pVrbnoXebSpKxobDLD 8cPplkY0zRHNIJjgR7+Viv79yiECn9MgHETamfE1LnQAQ0xrLA1vSMnSQb7FEGxg8i Rf7xVuteIGeeQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id a4CSc1ttJzEl; Tue, 20 Sep 2022 18:36:29 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 587A860F71; Tue, 20 Sep 2022 18:36:29 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 587A860F71 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 84D031BF2C6 for ; Tue, 20 Sep 2022 18:36:27 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5A47882849 for ; Tue, 20 Sep 2022 18:36:27 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 5A47882849 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0oSanNa0DK9l for ; Tue, 20 Sep 2022 18:36:26 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 177B382848 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id 177B382848 for ; Tue, 20 Sep 2022 18:36:25 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F36F662C79; Tue, 20 Sep 2022 18:36:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 016C4C433C1; Tue, 20 Sep 2022 18:36:23 +0000 (UTC) Date: Tue, 20 Sep 2022 11:36:23 -0700 From: Jakub Kicinski To: Li Zhong Message-ID: <20220920113623.2f041e80@kernel.org> In-Reply-To: <20220917001027.3799634-1-floridsleeves@gmail.com> References: <20220917001027.3799634-1-floridsleeves@gmail.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1663698984; bh=j06Czh6fa3r451X6L5qEQHRqs8sdGXQ7HkWUYOH22c8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gu4/i48+XxWPr1uruu55gEbwTWHJlH+OG28dQQm/ENFadcXowBBkssb6Vch85U07v FC3Wu23m7IyrejC2Y/rmkPW/6t2YQx8bLJ/zF/iEpTQ0qIhfswzGC0/HYVUI3GLlOq 7mwoc8ULpUamqtWtggk9WflM3sTQCQTaEtPJcBNRF0Rq1xWxl5thXLDSbT9zlTStKQ h8MNWmtgOkrVMJBENQnFIfci3FfuSNkK0CRhPmer2LG5SxhAGgkIF0FgRjxD14+haW Y2P2DK3sVTDIP99CkHVXq/3H35R6vuXvUdZBYxs9o7yg85ThSceuu8+MHzYw1MqRdE /lrhERQqzZ6OQ== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=gu4/i48+ Subject: Re: [Intel-wired-lan] [PATCH v2] drivers/net/ethernet/intel/e100: check the return value of e100_exec_cmd() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, edumazet@google.com, intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, 16 Sep 2022 17:10:27 -0700 Li Zhong wrote: > Check the return value of e100_exec_cmd() which could return error code > when execution fails. You need to provide more detailed analysis in the commit message. Right now it looks like you're just blindly finding cases where return value is not checked and adding error checks. This is as likely to fix something as it is to break. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan