From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0637C433FE for ; Fri, 7 Oct 2022 20:55:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 523B082735; Fri, 7 Oct 2022 20:55:56 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 523B082735 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1665176156; bh=Cm5540jYh3Bci61+Ex+mmq58RCgVgLgIZHs2xsZely0=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=FHtzHE0GPg2+0OSjaq/w0PGAAyUPnQEnA2dXqA5SS4/FAsShSlNomHHa+9ODX9JvD GasqeYoG1uYZedt7T6ojOrOhRdFDJ8D3dFm7+q9phGiArOrzw9SEJah6ktFEGKa9tN TRG4IoelRqYUyFXyLP0+08+HRDkTiY1OnBkPW7OC4j0e7XdLC/gwjKsK3VHD5Qglp5 ZmlgvEwsBhfyZpIEPL5St9MlipdoJLFgyAKZFKuXjTHbNZaFoAiqV1ZMy7jPRAOeWp u8fINnWlNAVgKBHBqJmHbrEzD3qE1tlt0jyt17tqjkARMiQnzJ4YOvOIoYpHMu80nU 0+YIH1AqnBKGA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5u6aV_TfGDVg; Fri, 7 Oct 2022 20:55:55 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 58F148283D; Fri, 7 Oct 2022 20:55:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 58F148283D Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 717A71BF350 for ; Fri, 7 Oct 2022 20:55:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 4BCD360812 for ; Fri, 7 Oct 2022 20:55:53 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 4BCD360812 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id atZZJTnpscHf for ; Fri, 7 Oct 2022 20:55:52 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8DE52607F2 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by smtp3.osuosl.org (Postfix) with ESMTPS id 8DE52607F2 for ; Fri, 7 Oct 2022 20:55:52 +0000 (UTC) Received: by mail-pg1-x535.google.com with SMTP id b5so5642492pgb.6 for ; Fri, 07 Oct 2022 13:55:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IFPWhrX4gIO5dljIOB1AVs/J7AIxycktaaljB/3y5TE=; b=itNvDPJe8TO40syWfV+r/17lvPMvz8KQG2lMlkX5Dwh0mhLrtv1XHs2II9eBPsAQB3 IL0h5uKlQDuKVcxRSPI/RSFB2ckd2R/N7NPBIA5+EtbOzLGaAQarmaBV/1blm2x0AZyG PznC1AqQuMJT6e9ddmxTcx68Rl+t1oYoVxRjGS/piBn30znS4dcVNrA8kMrZ4OkXZ7qT Ybsv5CZMKTO2fMma2/WfyQxArrU7lQRDdWwoGtULuqp5N++CNAuols9f8iOJKGq758nr V+6XqTDt4/BNAXX09Wcjq7ayKoskniAudvaluLlz1mrWr2TFaybuFrgrfR2fYrgczSaH zzjw== X-Gm-Message-State: ACrzQf3sl4CGo1opwTue00AqXPylvhPBOwyNEa13gXmL7Xj9p+oURso1 6vpYR69MUNm9pNHxGarSpJafqQ== X-Google-Smtp-Source: AMsMyM5ynb0ayFDpF0qOz1Muc+k+zDdevfazNbJKhwe4/n2m89iIiPLOE5BvxyKhwwkoJWz44NsJIg== X-Received: by 2002:a63:fd57:0:b0:43c:9a42:74fb with SMTP id m23-20020a63fd57000000b0043c9a4274fbmr6114525pgj.174.1665176151932; Fri, 07 Oct 2022 13:55:51 -0700 (PDT) Received: from fastly.com (c-24-6-151-244.hsd1.ca.comcast.net. [24.6.151.244]) by smtp.gmail.com with ESMTPSA id n9-20020a17090a160900b001f319e9b9e5sm5027722pja.16.2022.10.07.13.55.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Oct 2022 13:55:51 -0700 (PDT) Date: Fri, 7 Oct 2022 13:55:49 -0700 From: Joe Damato To: Jesse Brandeburg Message-ID: <20221007205548.GA49007@fastly.com> References: <1665165447-1802-1-git-send-email-jdamato@fastly.com> <25beff49-5564-dd48-c6db-d29b126677a0@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <25beff49-5564-dd48-c6db-d29b126677a0@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastly.com; s=google; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=IFPWhrX4gIO5dljIOB1AVs/J7AIxycktaaljB/3y5TE=; b=VstAuSCzctae/UrTiE31xi4DhUL3U/EtKRvAgM3WBdobwp9bVW3puJYhhKkV1j9Von NdiMNzRyuUUPa27H7JN0NntkOQ2mF3ADOfr4BBwCVJKG4f0QyxybKmk2rytmCzgJZko9 nIx/OqSwWP6ViskYRss/qRitRJBDpJceU8FH8= X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (1024-bit key) header.d=fastly.com header.i=@fastly.com header.a=rsa-sha256 header.s=google header.b=VstAuSCz Subject: Re: [Intel-wired-lan] [RFC, next-queue 0/4] i40e: Add a non-XDP i40e_napi_poll tracepoint X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-wired-lan@lists.osuosl.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Oct 07, 2022 at 01:36:20PM -0700, Jesse Brandeburg wrote: > On 10/7/2022 10:57 AM, Joe Damato wrote: > >Greetings: > > > >This is an RFC which is similar to the series up for review, except that > >this implementation does not touch XDP at all and adds a conditional in > >i40e_napi_poll to only fire the tracepoint when XDP is not enabled. > > > >This should avoid the issues that Maciej has with the naming of out > >parameters (since none of that code is touched in this series) and it > >clears the way for Maciej, Sridhar, et al to implement the XDP tracepoint. > > > >I am submitting this an alternative to what's already up for review. > > > >If you prefer to accept this code, please let me know that you want the > >non-XDP version and I'll submit it as the 'v4'. > > Given the discussion, this is the series I prefer. I'm very happy to see > some more debugging helpers coming into the driver so thanks for your work > on this Joe! As for the rest of the team they seem to be fine speaking for > themselves, so I imagine they'll let you know :-) > > For the series: > Acked-by: Jesse Brandeburg OK, thanks! There's a minor build failure for a format string (lu should be u) in the tracepoint. I'll fix that now in this series and re-send it as a v4 with a proper cover letter. Thanks again for your detailed feedback and review; I appreciate your time and energy on this. Thanks, Joe _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan