From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 46B6CC433FE for ; Fri, 4 Nov 2022 18:47:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BED6141994; Fri, 4 Nov 2022 18:47:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org BED6141994 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1667587662; bh=dGV78sWcu6KQNkg2KZGJNnIFD5Z9fpOSFTD9SfL+5Zw=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=qaWPEejRAo8spvEZV7VjkN1rLPQKsXDOrMNrG72GL1qk0XjoLT5dy1zfZCjjspEtZ HAprufkab/l31rewRGVUKmuG+dYUzzlmbgy7rd06lHJ94OUPhxdBxgHqqLc+z3sSxM azdXg1TZltRZMJhKlciGphJY3M/0iwyxLR/T04N90NpEerXS8QXFlfNkjtgEeFyFaX psK+92Vv5dd8MPhpSl/JStKroSPHKIqo2VA7a5M16MPmu4NoQtBemV0zQ1DI9hx6Dm CyQZT0FlqNtu5j+gp5dxgaVsYBTndyOi0L4TfPK7BIVWOPOkutiDRTTkOnHPFnVsdg ms2WYJMLS9KVw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WvXy4TDi7BTF; Fri, 4 Nov 2022 18:47:40 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 074EA41992; Fri, 4 Nov 2022 18:47:40 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 074EA41992 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 830F71BF5E9 for ; Fri, 4 Nov 2022 18:47:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 6631B403CA for ; Fri, 4 Nov 2022 18:47:38 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6631B403CA X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n6aXYOww0pNR for ; Fri, 4 Nov 2022 18:47:37 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 86F474011F Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp2.osuosl.org (Postfix) with ESMTPS id 86F474011F for ; Fri, 4 Nov 2022 18:47:37 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 93AD1CE2D8B; Fri, 4 Nov 2022 18:47:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7088FC433C1; Fri, 4 Nov 2022 18:47:31 +0000 (UTC) Date: Fri, 4 Nov 2022 11:47:30 -0700 From: Jakub Kicinski To: Tony Nguyen Message-ID: <20221104114730.42294e1c@kernel.org> In-Reply-To: <003bc385-dc14-12ba-d3d6-53de3712a5dc@intel.com> References: <20221031114456.10482-1-jirislaby@kernel.org> <20221102204110.26a6f021@kernel.org> <003bc385-dc14-12ba-d3d6-53de3712a5dc@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1667587651; bh=FCVLnWzagH7Ltd74TWHda9yHbM/ThxqIP+R6QjDXusQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K8hlD+njx6G0TqbVm5Fth4CASD4xRSsQn3RzlPzp94KN29oCnPq1QW9c+GhArw0lr IQV8gpSUILgpCglcGFRxTTIEVu1IfaPnMuRSqcLulzeSRZBwyFfxm5DPY3KkKH/1XE iSDtWmLg+4zjj/QSfMgcNWeO3kXacE7WifGznlQF/rfapUXZUCNb5sTi8cpbbuhm8u HDBnUcSH2d2i2GM6C12emCculNjc1Ze801WOqR9G0RSVwKLF9LR4+kmtJKjfLRjvNe JlJHOrX1NojuKHc1moNVg0FzATcdR3XD0Y6vUNrtrNaoZcn0EO03RExhAOesjgH+tw 83q/IgxOqpz1w== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=K8hlD+nj Subject: Re: [Intel-wired-lan] [PATCH] i40e (gcc13): synchronize allocate/free functions return type & values X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jiri Slaby , linux-kernel@vger.kernel.org, "Loktionov, Aleksandr" , Eric Dumazet , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Paolo Abeni , Martin Liska , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, 4 Nov 2022 11:33:07 -0700 Tony Nguyen wrote: > As Jiri mentioned, this is propagated up throughout the driver. We could > change this function to return int but all the callers would then need > to convert these errors to i40e_status to propagate. This doesn't really > gain much other than having this function return int. To adjust the > entire call chain is going to take more work. As this is resolving a > valid warning and returning what is currently expected, what are your > thoughts on taking this now to resolve the issue and our i40e team will > take the work on to convert the functions to use the standard errnos? My thoughts on your OS abstraction layers should be pretty evident. If anything I'd like to be more vigilant about less flagrant cases. I don't think this is particularly difficult, let's patch it up best we can without letting the "status" usage grow. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan