From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D639FC4332F for ; Tue, 15 Nov 2022 05:09:04 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 6343E402E1; Tue, 15 Nov 2022 05:09:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6343E402E1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1668488944; bh=MRap2iTvjBDEG+3bE/Ftu5IAhc95ZYubh7j6qSnJ154=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=0hYTXQdC/Zsa1yLfQxBzHJR1lcfFeLmDSvlz8D2jKLp4Au8kbdKoUUqnVTbaVXj7k PYE+HsCuCtH4fUxrf+Ev82IJSj390raJFOYnAHDUCs0szFLEnU0mcRwDfOmCSqPwxe UmSmL3rKopVWXk882/yDt7tqVUSglsX2ibwPN4FXX8qDOncshVp2O9Ag+5gdCpG51M PzgXMzAZ1+CMh5Rwv8jerCkAU8xKvuf0HcNrjD5+mRQ8+EtuJiAR0rLLNu3CUurVaw Nl3wO9jywVHwehfuYKjx7ezwwk1lVA/QfKc5p6RBPYmupN+V9e+cfI7oDffzNysr8j 7KRr88jkN6AGA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0knDTCtRw_lE; Tue, 15 Nov 2022 05:09:03 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 3887C40309; Tue, 15 Nov 2022 05:09:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 3887C40309 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id D68611BF2B0 for ; Tue, 15 Nov 2022 05:09:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BD08D40309 for ; Tue, 15 Nov 2022 05:09:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org BD08D40309 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jNjHmToW5Wot for ; Tue, 15 Nov 2022 05:09:00 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org E08F5402E1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id E08F5402E1 for ; Tue, 15 Nov 2022 05:08:59 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1D14D61487; Tue, 15 Nov 2022 05:08:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ABD17C433D6; Tue, 15 Nov 2022 05:08:57 +0000 (UTC) Date: Mon, 14 Nov 2022 21:08:56 -0800 From: Jakub Kicinski To: Michal Swiatkowski Message-ID: <20221114210856.0d76bb2c@kernel.org> In-Reply-To: <20221114125755.13659-13-michal.swiatkowski@linux.intel.com> References: <20221114125755.13659-1-michal.swiatkowski@linux.intel.com> <20221114125755.13659-13-michal.swiatkowski@linux.intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668488938; bh=bBPdVJBnQflcUos860RsE9Maik4P+Mc7RQiwH/m90FQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Khrc7B0yZonEQ1V07JxaEdOZ700mxv+4bKUYxqy6qka4PV3faSKkT5COqRHlHYIkd +03vXjqgjJ4aFB19dYXrr9WNVBanTPosuVcoXqiuGDCJxTvwf4b0eRijI+nEkP6NzE OWhaaQwsGsLc3UjVPRntTDpK/kbkWiDAMRpu9GY+RzCLQVotmSLME6J83nEwsm0S4Q CQ+BCTEiS5EK37D++bd/n7m8sga1CS2RJh6e5bk0/VDzZ9RHSXaMqgsaw7Y9kepiZL DyGAeLe/83pxL/X6VB9rdoRfVSsKFy95DkPiSvOaF94dSna9S8bM16Ek1PNwpT7eWI QFZ4sxjuzA5qA== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Khrc7B0y Subject: Re: [Intel-wired-lan] [PATCH net-next 12/13] ice, irdma: prepare reservation of MSI-X to reload X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mustafa.ismail@intel.com, netdev@vger.kernel.org, leszek.kaliszczuk@intel.com, przemyslaw.kitszel@intel.com, edumazet@google.com, intel-wired-lan@lists.osuosl.org, jiri@nvidia.com, pabeni@redhat.com, shiraz.saleem@intel.com, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 14 Nov 2022 13:57:54 +0100 Michal Swiatkowski wrote: > Move MSI-X number for LAN and RDMA to structure to have it in one > place. Use req_msix to store how many MSI-X for each feature user > requested. Structure msix is used to store the current number of MSI-X. > > The MSI-X number needs to be adjust if kernel doesn't support that many > MSI-X or if hardware doesn't support it. Rewrite MSI-X adjustment > function to use it in both cases. > > Use the same algorithm like previously. First allocate minimum MSI-X for > each feature than if there is enough MSI-X distribute it equally between > each one. drivers/net/ethernet/intel/ice/ice_lib.c:455: warning: Function parameter or member 'vsi' not described in 'ice_vsi_alloc_def' drivers/net/ethernet/intel/ice/ice_lib.c:455: warning: Excess function parameter 'vsi_type' description in 'ice_vsi_alloc_def' drivers/net/ethernet/intel/ice/ice_main.c:4026:9: warning: variable 'err' is uninitialized when used here [-Wuninitialized] return err; ^~~ drivers/net/ethernet/intel/ice/ice_main.c:4001:29: note: initialize the variable 'err' to silence this warning int v_wanted, v_actual, err, i; ^ = 0 _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan