[Intel-wired-lan] [PATCH net-next v2 2/5] mlxsw: core: fix mlxsw_devlink_info_get() to correctly report driver name

From: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
To: Jiri Pirko <jiri@nvidia.com>,
	netdev@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Simon Horman <simon.horman@corigine.com>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	Eric Dumazet <edumazet@google.com>,
	Jerin Jacob <jerinj@marvell.com>,
	Subbaraya Sundeep <sbhatta@marvell.com>,
	Ioana Ciornei <ioana.ciornei@nxp.com>,
	drivers@pensando.io, Linu Cherian <lcherian@marvell.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Leon Romanovsky <leon@kernel.org>,
	linux-rdma@vger.kernel.org, Shalom Toledo <shalomt@mellanox.com>,
	Srujana Challa <schalla@marvell.com>,
	Shannon Nelson <snelson@pensando.io>,
	intel-wired-lan@lists.osuosl.org, Vadim Fedorenko <vadfed@fb.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Yisen Zhuang <yisen.zhuang@huawei.com>,
	Sunil Goutham <sgoutham@marvell.com>,
	Ariel Elior <aelior@marvell.com>,
	Ido Schimmel <idosch@nvidia.com>,
	Richard Cochran <richardcochran@gmail.com>,
	Arnaud Ebalard <arno@natisbad.org>,
	Ido Schimmel <idosch@mellanox.com>,
	Michael Chan <michael.chan@broadcom.com>,
	Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
	Petr Machata <petrm@nvidia.com>,
	Salil Mehta <salil.mehta@huawei.com>,
	Dimitris Michailidis <dmichail@fungible.com>,
	Manish Chopra <manishc@marvell.com>,
	Boris Brezillon <bbrezillon@kernel.org>,
	oss-drivers@corigine.com, Vadim Pasternak <vadimp@mellanox.com>,
	linux-kernel@vger.kernel.org,
	"David S . Miller" <davem@davemloft.net>,
	Taras Chornyi <tchornyi@marvell.com>,
	hariprasad <hkelam@marvell.com>,
	linux-crypto@vger.kernel.org,
	Jonathan Lemon <jonathan.lemon@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	Saeed Mahameed <saeedm@nvidia.com>,
	Geetha sowjanya <gakula@marvell.com>
Subject: [Intel-wired-lan] [PATCH net-next v2 2/5] mlxsw: core: fix mlxsw_devlink_info_get() to correctly report driver name
Date: Sun, 27 Nov 2022 17:16:01 +0900	[thread overview]
Message-ID: <20221127081604.5242-3-mailhol.vincent@wanadoo.fr> (raw)
In-Reply-To: <20221127081604.5242-1-mailhol.vincent@wanadoo.fr>

Currently, mlxsw_devlink_info_get() reports the device_kind. The
device_kind is not necessarily the same as the device_name. For
example, the mlxsw_i2c implementation sets up the device_kind as
ic2_client::name in [1] which indicates the type of the device
(e.g. chip name).

Fix it so that it correctly reports the driver name.

[1] https://elixir.bootlin.com/linux/v6.1-rc1/source/drivers/net/ethernet/mellanox/mlxsw/i2c.c#L714

Fixes: a9c8336f6544 ("mlxsw: core: Add support for devlink info command")
CC: Shalom Toledo <shalomt@mellanox.com>
CC: Ido Schimmel <idosch@mellanox.com>
CC: Vadim Pasternak <vadimp@mellanox.com>
Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
---
 drivers/net/ethernet/mellanox/mlxsw/core.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c
index a83f6bc30072..d8b1bb03cdb0 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/core.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/core.c
@@ -1453,6 +1453,7 @@ mlxsw_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req,
 		       struct netlink_ext_ack *extack)
 {
 	struct mlxsw_core *mlxsw_core = devlink_priv(devlink);
+	struct device *dev = mlxsw_core->bus_info->dev;
 	char fw_info_psid[MLXSW_REG_MGIR_FW_INFO_PSID_SIZE];
 	u32 hw_rev, fw_major, fw_minor, fw_sub_minor;
 	char mgir_pl[MLXSW_REG_MGIR_LEN];
@@ -1460,7 +1461,7 @@ mlxsw_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req,
 	int err;
 
 	err = devlink_info_driver_name_put(req,
-					   mlxsw_core->bus_info->device_kind);
+					   dev_driver_string(dev->parent));
 	if (err)
 		return err;
 
-- 
2.37.4

_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
