From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D385C4332F for ; Mon, 28 Nov 2022 18:42:12 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BD0C64098D; Mon, 28 Nov 2022 18:42:11 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org BD0C64098D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1669660931; bh=BSbiCfcrJCa88CD9fxnnd9jf1NI2Tw5lZxd6H7UQABc=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Nd1CEDMS9G0XgJpjzAcfC6HQlRLkcExBwb35cjVLs2uIA3IQtM18UlBI0ItA7VTfS MJ3tS3t1pFfFsR1HKpDC52AJznxe3YXEgMFnMGUKNqY/x6M119C5FpVg18l/DGKSIu RwxlSvXFY32Zl/5bzRgaF6CLGiHsAk56XuOYBEMZdJhoZcxJ/DpYN6rWqiK986yvQV U7gdhxIU/oqC46TtRzAR3bGDHHO45/qybiSpnQBBdEIaqkv28H3QbfvmK0f2apxW7V ZhNlctb3F++NVZInmvxE4Qahws4nN87liHLVexpZgBaAbQysYN0E/HHAb3xmlMWqHZ Uy2Q0wlbh5rbw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H_ftzjEDemdk; Mon, 28 Nov 2022 18:42:10 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 8800C409A5; Mon, 28 Nov 2022 18:42:10 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 8800C409A5 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id CEE6A1BF377 for ; Mon, 28 Nov 2022 18:42:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id A5B3660590 for ; Mon, 28 Nov 2022 18:42:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org A5B3660590 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XrPQq109mRYm for ; Mon, 28 Nov 2022 18:42:08 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org E275A60017 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp3.osuosl.org (Postfix) with ESMTPS id E275A60017 for ; Mon, 28 Nov 2022 18:42:07 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0E45D611D4; Mon, 28 Nov 2022 18:42:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3B1DC433D6; Mon, 28 Nov 2022 18:42:04 +0000 (UTC) Date: Mon, 28 Nov 2022 10:42:03 -0800 From: Jakub Kicinski To: Vincent Mailhol Message-ID: <20221128104203.079ce802@kernel.org> In-Reply-To: <20221128041545.3170897-4-mailhol.vincent@wanadoo.fr> References: <20221122154934.13937-1-mailhol.vincent@wanadoo.fr> <20221128041545.3170897-1-mailhol.vincent@wanadoo.fr> <20221128041545.3170897-4-mailhol.vincent@wanadoo.fr> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669660926; bh=c/Kya75Gow4UGO+kWaBvGk9V0lZ53wcA1385i+8THwU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ggtZa/EXaHIafcJ28igxOSiRe6MpAjEMroyUUXUKor1ZOYtErOk9h4Pg1uPxHTxPJ 8uAReJ0QZbagmOuMZEltNe1MCOovSlZ6aKjAFkKJBjOktJHPOOcJUdIGoDPi6uUQ20 MXyNg8MjRmfA8OWJbemROMNNwero5+hww9jG3uqbHEl6XgfqMRA95nQWL2mU4WLE38 Hta0auaTwNimuhOfvVFOfz8grj/MzLiZ83WQRvmPdQ///4aXS7FjPvsfYQLqXw3cOa FzX7m1h0inABUmO0kFCTG9vaaUHpJAcoA7JqFSsdD78EQAPQM+He4ME9C0JSq2ajri +/RYwrUokWRUQ== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=ggtZa/EX Subject: Re: [Intel-wired-lan] [PATCH net-next v4 3/3] net: devlink: make the devlink_ops::info_get() callback optional X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Shijith Thotton , Simon Horman , Kurt Kanzenbach , Eric Dumazet , Subbaraya Sundeep , Ioana Ciornei , drivers@pensando.io, Linu Cherian , Florian Fainelli , Herbert Xu , Leon Romanovsky , linux-rdma@vger.kernel.org, Shalom Toledo , Srujana Challa , Minghao Chi , Hao Chen , Guangbin Huang , Shannon Nelson , intel-wired-lan@lists.osuosl.org, Vadim Fedorenko , Paolo Abeni , Yisen Zhuang , Sunil Goutham , Ariel Elior , Ido Schimmel , Richard Cochran , Arnaud Ebalard , Jiri Pirko , Jiri Pirko , Michael Chan , Petr Machata , Salil Mehta , Dimitris Michailidis , Manish Chopra , Boris Brezillon , netdev@vger.kernel.org, oss-drivers@corigine.com, Vadim Pasternak , linux-kernel@vger.kernel.org, Geetha sowjanya , Taras Chornyi , hariprasad , linux-crypto@vger.kernel.org, Jonathan Lemon , Jerin Jacob , Vladimir Oltean , Saeed Mahameed , "David S . Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 28 Nov 2022 13:15:45 +0900 Vincent Mailhol wrote: > Some drivers only reported the driver name in their > devlink_ops::info_get() callback. Now that the core provides this > information, the callback became empty. For such drivers, just > removing the callback would prevent the core from executing > devlink_nl_info_fill() meaning that "devlink dev info" would not > return anything. > > Make the callback function optional by executing > devlink_nl_info_fill() even if devlink_ops::info_get() is NULL. > > Remove all the empty devlink_ops::info_get() functions from the > drivers. > > N.B.: the drivers with devlink support which previously did not > implement devlink_ops::info_get() will now also be able to report > the driver name. These should be two separate patches, tho. Please don't post v5 in-reply-to. Otherwise looks good. Kinda risky but good :) _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan