From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 558AAC4332F for ; Mon, 5 Dec 2022 19:53:19 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0147C41681; Mon, 5 Dec 2022 19:53:19 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 0147C41681 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1670269999; bh=J7mtnKs9BxbWWcwyuMNh6FQ1YUjqrgHS7r0ClpQzSBs=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=VgBx4/wm5L/Rry11E0zUzGEWeP6lWMhKY2FAsD3EZ6MfSaTbJZBvDvwf1YFIv5mie 6yolWgTTnrluTLD2W0ajeSGIJfHabz6BgMomrxWMu4okz2AfGDu9tdYaUCm+wkj3qs DYRMNDG4o+gJa+xA/JncgQepVGNzHa1DyVWx21IxhOk/hwj+X3YXLkIewGbMeOTgi4 11XuvALZIieq6CKUyaSRslKIu2HLUfVxvkE6He6HGLpYYEz2DiRaaN/6sfFCAXygym CKQ0qN1FFn8qoRhlEs7S/YGGdEPU282kBRWgDigUTNfS1wU7nPBozcv8D51jQ4B7B5 yfH+DjZ+ugzVA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8eaJpELqocoL; Mon, 5 Dec 2022 19:53:18 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id B9DB841685; Mon, 5 Dec 2022 19:53:17 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B9DB841685 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 19E6C1BF3EF for ; Mon, 5 Dec 2022 19:53:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 29460818D7 for ; Mon, 5 Dec 2022 19:53:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 29460818D7 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id UiO4Vas1xxnL for ; Mon, 5 Dec 2022 19:53:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 78A64818C2 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by smtp1.osuosl.org (Postfix) with ESMTPS id 78A64818C2 for ; Mon, 5 Dec 2022 19:53:03 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6500,9779,10552"; a="317592370" X-IronPort-AV: E=Sophos;i="5.96,220,1665471600"; d="scan'208";a="317592370" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2022 11:53:01 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10552"; a="709379288" X-IronPort-AV: E=Sophos;i="5.96,220,1665471600"; d="scan'208";a="709379288" Received: from jekeller-desk.amr.corp.intel.com (HELO jekeller-desk.jekeller.internal) ([10.166.241.7]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2022 11:53:00 -0800 From: Jacob Keller To: Intel Wired LAN Date: Mon, 5 Dec 2022 11:52:42 -0800 Message-Id: <20221205195253.2475492-5-jacob.e.keller@intel.com> X-Mailer: git-send-email 2.38.1.420.g319605f8f00e In-Reply-To: <20221205195253.2475492-1-jacob.e.keller@intel.com> References: <20221205195253.2475492-1-jacob.e.keller@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1670269983; x=1701805983; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=dNJIPftn2WMQGwchjW9gj7Vlqu8M+taGjHkyfIFyrqU=; b=nrWMABXU8dnI7UkMfSfXrPIl2q2vPbaZjP6qguDczE4k+R/lRnO7X5yI Ej6SGP/G3iZhTOAmhuRUNxzbGPMAgOe5DUd55zJt/viR+EprrC7dV40b/ oULQPBBLDvQTIWBe79tJfRoG+rl9gPL+7cDpKLmUK8kydSDbQ5wurNNFN VM1wYCrJrkbTVFhZGvm9tIdNRL9KAbpvb7AWF67iwwUwUKFQGGTKf3a7f QF3J89S2Cdhk9HaBJS8XBgtsowitT1SPtvTfZ++OXvlCxfIvapd+v4r3k zpLxJQBqr87PpIXJc3xyScrfNePZB7BnwREgznOtF8U1B73L637tiHDsV w==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=nrWMABXU Subject: [Intel-wired-lan] [PATCH net-next v3 04/15] ice: fix misuse of "link err" with "link status" X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" The ice_ptp_link_change function has a comment which mentions "link err" when referring to the current link status. We are storing the status of whether link is up or down, which is not an error. It is appears that this use of err accidentally got included due to an overzealous search and replace when removing the ice_status enum and local status variable. Fix the wording to use the correct term. Signed-off-by: Jacob Keller Tested-by: Gurucharan G (A Contingent worker at Intel) Signed-off-by: Tony Nguyen --- No changes since v2. drivers/net/ethernet/intel/ice/ice_ptp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c b/drivers/net/ethernet/intel/ice/ice_ptp.c index f93fa0273252..5607ec578499 100644 --- a/drivers/net/ethernet/intel/ice/ice_ptp.c +++ b/drivers/net/ethernet/intel/ice/ice_ptp.c @@ -1347,7 +1347,7 @@ int ice_ptp_link_change(struct ice_pf *pf, u8 port, bool linkup) if (ptp_port->port_num != port) return -EINVAL; - /* Update cached link err for this port immediately */ + /* Update cached link status for this port immediately */ ptp_port->link_up = linkup; if (!test_bit(ICE_FLAG_PTP, pf->flags)) -- 2.38.1.420.g319605f8f00e _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan