From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 195AEC3DA7A for ; Thu, 5 Jan 2023 18:45:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 983198211E; Thu, 5 Jan 2023 18:45:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 983198211E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1672944326; bh=zOmQ9J11KgdQNvKJbFzq9RB2vEzzedRFtvJwGIREDUE=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=zTsmjXSjT55DTVyJML/Bt1fPM+XIau50SCF3/pE4YjjuQ9UY2nh9SA6msBVJD9lrT 7iBkk824dMxuB6VAVFNacY0dLXRCLdGG/pC7AIkHbVTRVQtOZU47XJ5T9AQb2kSXGO tDQqOAp6BMTPE2MJ8wp9Jg2eAyqiuidRGjjD1HZ7h/mMttz/Xnf22DG7eJ/Piu9ARJ 1mQbz+FbAUuYHuLPttuuqLxHL8eTFqAFCmxAWA0C7fszoS2gL4JnQ88TxziJldyC3m SKcf+kaLuob04SpifOqC/2kuwmmGOFfeP4GNneOy42EOpk5ONJjyQ1OJppuwE78unT Fle2V/vJfFtRw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id C8ri6N8QeyCX; Thu, 5 Jan 2023 18:45:26 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id B86E0820FF; Thu, 5 Jan 2023 18:45:25 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org B86E0820FF Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 790E81BF267 for ; Thu, 5 Jan 2023 18:45:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 513DF419BF for ; Thu, 5 Jan 2023 18:45:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 513DF419BF X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wWOyp73T2lGj for ; Thu, 5 Jan 2023 18:45:23 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D2B54419B8 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by smtp4.osuosl.org (Postfix) with ESMTPS id D2B54419B8 for ; Thu, 5 Jan 2023 18:45:22 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7D0E0B81BA8; Thu, 5 Jan 2023 18:45:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D058EC433D2; Thu, 5 Jan 2023 18:45:18 +0000 (UTC) Date: Thu, 5 Jan 2023 10:45:17 -0800 From: Jakub Kicinski To: Mateusz Palczewski Message-ID: <20230105104517.79cd83ed@kernel.org> In-Reply-To: <20230105120518.29776-1-mateusz.palczewski@intel.com> References: <20230105120518.29776-1-mateusz.palczewski@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672944319; bh=Wvox5HO5U/l/+KdMek/+nOY1pCCL4DRB2EMvkbt+Czs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hLExPmDGQXGapRDuaDYLNVrg9nHY0c5GvhqT+rjFjEoQjTc03Fmtu1tCUZCi57JPN +Thw8zR0HP/UpS3OBCqNem9YCetLBfTqJAtJNbGoj0EtspEmNzjGUbaHTq1BtsHyo9 /U/lMFNJMOMApLo5mX9hUu+wKjtOUTEiiZbqpzMZrni11zbKsYI2Ie22uCbCk1TRpM H9RhYB5hsiOxomw0yZ7uJ9rSa8AsBnMWwsK+UrP05UbJ9gFXuMmCARiMr8CHHyj0N0 9cLeLD9Thqt50LEqL0Po4m5VX4uQWFF2qbLbFKMSQdY7UJn1G3ydfLCWw7Sjn7OIxP SWUZyq/6EzA7w== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=hLExPmDG Subject: Re: [Intel-wired-lan] [PATCH net v2] ice: Fix deadlock on the rtnl_mutex X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, leon@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, 5 Jan 2023 07:05:18 -0500 Mateusz Palczewski wrote: > ret = ice_vsi_alloc_q_vectors(vsi); > - if (ret) > - goto err_rings; > + if (ret){ > + ice_vsi_clear_rings(vsi); > + goto err_reset; > + } > > ret = ice_vsi_setup_vector_base(vsi); > if (ret) Why do cases which jump to err_vectors no need any changes? _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan