From: Dan Carpenter <error27@gmail.com>
To: oe-kbuild@lists.linux.dev,
Sylwester Dziedziuch <sylwesterx.dziedziuch@intel.com>
Cc: Kamil Maziarz <kamil.maziarz@intel.com>,
Andrii Staikov <andrii.staikov@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
oe-kbuild-all@lists.linux.dev,
Intel Wired LAN <intel-wired-lan@lists.osuosl.org>
Subject: [Intel-wired-lan] [tnguy-net-queue:dev-queue 17/18] drivers/net/ethernet/intel/i40e/i40e_main.c:13383 i40e_xdp_setup() warn: missing error code 'ret'
Date: Mon, 9 Jan 2023 11:23:18 +0300 [thread overview]
Message-ID: <202301090023.M6DN1R1S-lkp@intel.com> (raw)
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git dev-queue
head: 1504740fc0229fa18e23c48232af1b8ef66608b2
commit: 599984216d420ff4877ba95f5bdb3cf0928206c0 [17/18] i40e: Fix crash when rebuild fails in i40e_xdp_setup
config: arc-randconfig-m031-20230108
compiler: arceb-elf-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
New smatch warnings:
drivers/net/ethernet/intel/i40e/i40e_main.c:13383 i40e_xdp_setup() warn: missing error code 'ret'
Old smatch warnings:
drivers/net/ethernet/intel/i40e/i40e_main.c:13573 i40e_queue_pair_toggle_rings() warn: missing error code? 'ret'
drivers/net/ethernet/intel/i40e/i40e_main.c:14361 i40e_vsi_setup_vectors() warn: missing error code? 'ret'
vim +/ret +13383 drivers/net/ethernet/intel/i40e/i40e_main.c
613142b0bb8840 Eryk Rybak 2021-01-14 13350 static int i40e_xdp_setup(struct i40e_vsi *vsi, struct bpf_prog *prog,
613142b0bb8840 Eryk Rybak 2021-01-14 13351 struct netlink_ext_ack *extack)
0c8493d90b6bb0 Björn Töpel 2017-05-24 13352 {
0c8493d90b6bb0 Björn Töpel 2017-05-24 13353 int frame_size = vsi->netdev->mtu + ETH_HLEN + ETH_FCS_LEN + VLAN_HLEN;
599984216d420f Sylwester Dziedziuch 2022-12-21 13354 bool is_xdp_enabled = i40e_enabled_xdp_vsi(vsi);
599984216d420f Sylwester Dziedziuch 2022-12-21 13355 bool if_running = netif_running(vsi->netdev);
599984216d420f Sylwester Dziedziuch 2022-12-21 13356 bool need_reinit = is_xdp_enabled != !!prog;
0c8493d90b6bb0 Björn Töpel 2017-05-24 13357 struct i40e_pf *pf = vsi->back;
0c8493d90b6bb0 Björn Töpel 2017-05-24 13358 struct bpf_prog *old_prog;
599984216d420f Sylwester Dziedziuch 2022-12-21 13359 int ret = 0;
0c8493d90b6bb0 Björn Töpel 2017-05-24 13360
0c8493d90b6bb0 Björn Töpel 2017-05-24 13361 /* Don't allow frames that span over multiple buffers */
0c87b545a2ed5c Bartosz Staszewski 2022-12-09 13362 if (frame_size > i40e_calculate_vsi_rx_buf_len(vsi)) {
613142b0bb8840 Eryk Rybak 2021-01-14 13363 NL_SET_ERR_MSG_MOD(extack, "MTU too large to enable XDP");
0c8493d90b6bb0 Björn Töpel 2017-05-24 13364 return -EINVAL;
613142b0bb8840 Eryk Rybak 2021-01-14 13365 }
0c8493d90b6bb0 Björn Töpel 2017-05-24 13366
6533e558c6505e Karen Sornek 2022-01-12 13367 /* VSI shall be deleted in a moment, just return EINVAL */
6533e558c6505e Karen Sornek 2022-01-12 13368 if (test_bit(__I40E_IN_REMOVE, pf->state))
6533e558c6505e Karen Sornek 2022-01-12 13369 return -EINVAL;
6533e558c6505e Karen Sornek 2022-01-12 13370
0c8493d90b6bb0 Björn Töpel 2017-05-24 13371 old_prog = xchg(&vsi->xdp_prog, prog);
0c8493d90b6bb0 Björn Töpel 2017-05-24 13372
599984216d420f Sylwester Dziedziuch 2022-12-21 13373 if (!need_reinit)
599984216d420f Sylwester Dziedziuch 2022-12-21 13374 goto assign_prog;
599984216d420f Sylwester Dziedziuch 2022-12-21 13375
599984216d420f Sylwester Dziedziuch 2022-12-21 13376 if (if_running && !test_and_set_bit(__I40E_VSI_DOWN, vsi->state))
599984216d420f Sylwester Dziedziuch 2022-12-21 13377 i40e_down(vsi);
599984216d420f Sylwester Dziedziuch 2022-12-21 13378
599984216d420f Sylwester Dziedziuch 2022-12-21 13379 vsi = i40e_vsi_reinit_setup(vsi, true);
599984216d420f Sylwester Dziedziuch 2022-12-21 13380
599984216d420f Sylwester Dziedziuch 2022-12-21 13381 if (!vsi) {
599984216d420f Sylwester Dziedziuch 2022-12-21 13382 NL_SET_ERR_MSG_MOD(extack, "Failed to reinitialize VSI during XDP setup");
599984216d420f Sylwester Dziedziuch 2022-12-21 @13383 goto err_vsi_setup;
ret = -ESOMETHING;
b3873a5be757b4 Maxim Mikityanskiy 2019-12-17 13384 }
0c8493d90b6bb0 Björn Töpel 2017-05-24 13385
599984216d420f Sylwester Dziedziuch 2022-12-21 13386 /* allocate descriptors */
599984216d420f Sylwester Dziedziuch 2022-12-21 13387 ret = i40e_vsi_setup_tx_resources(vsi);
599984216d420f Sylwester Dziedziuch 2022-12-21 13388 if (ret) {
599984216d420f Sylwester Dziedziuch 2022-12-21 13389 NL_SET_ERR_MSG_MOD(extack, "Failed to configure TX resources during XDP setup");
599984216d420f Sylwester Dziedziuch 2022-12-21 13390 goto err_setup_tx;
599984216d420f Sylwester Dziedziuch 2022-12-21 13391 }
599984216d420f Sylwester Dziedziuch 2022-12-21 13392 ret = i40e_vsi_setup_rx_resources(vsi);
599984216d420f Sylwester Dziedziuch 2022-12-21 13393 if (ret) {
599984216d420f Sylwester Dziedziuch 2022-12-21 13394 NL_SET_ERR_MSG_MOD(extack, "Failed to configure RX resources during XDP setup");
599984216d420f Sylwester Dziedziuch 2022-12-21 13395 goto err_setup_rx;
aae425efdfd1b1 Jan Sokolowski 2022-10-12 13396 }
aae425efdfd1b1 Jan Sokolowski 2022-10-12 13397
599984216d420f Sylwester Dziedziuch 2022-12-21 13398 if (!is_xdp_enabled && prog)
599984216d420f Sylwester Dziedziuch 2022-12-21 13399 ret = i40e_realloc_rx_bi_zc(vsi, true);
599984216d420f Sylwester Dziedziuch 2022-12-21 13400 else if (is_xdp_enabled && !prog)
599984216d420f Sylwester Dziedziuch 2022-12-21 13401 ret = i40e_realloc_rx_bi_zc(vsi, false);
599984216d420f Sylwester Dziedziuch 2022-12-21 13402
599984216d420f Sylwester Dziedziuch 2022-12-21 13403 if (ret) {
599984216d420f Sylwester Dziedziuch 2022-12-21 13404 NL_SET_ERR_MSG_MOD(extack, "Failed to reallocate RX resources during XDP setup");
599984216d420f Sylwester Dziedziuch 2022-12-21 13405 goto err_vsi_setup;
599984216d420f Sylwester Dziedziuch 2022-12-21 13406 }
599984216d420f Sylwester Dziedziuch 2022-12-21 13407
599984216d420f Sylwester Dziedziuch 2022-12-21 13408 if (if_running) {
599984216d420f Sylwester Dziedziuch 2022-12-21 13409 ret = i40e_up(vsi);
599984216d420f Sylwester Dziedziuch 2022-12-21 13410
599984216d420f Sylwester Dziedziuch 2022-12-21 13411 if (ret) {
599984216d420f Sylwester Dziedziuch 2022-12-21 13412 NL_SET_ERR_MSG_MOD(extack, "Failed to open VSI during XDP setup");
599984216d420f Sylwester Dziedziuch 2022-12-21 13413 goto err_vsi_setup;
599984216d420f Sylwester Dziedziuch 2022-12-21 13414 }
599984216d420f Sylwester Dziedziuch 2022-12-21 13415 }
599984216d420f Sylwester Dziedziuch 2022-12-21 13416
599984216d420f Sylwester Dziedziuch 2022-12-21 13417 assign_prog:
599984216d420f Sylwester Dziedziuch 2022-12-21 13418 i40e_vsi_assign_bpf_prog(vsi, prog);
0c8493d90b6bb0 Björn Töpel 2017-05-24 13419
0c8493d90b6bb0 Björn Töpel 2017-05-24 13420 if (old_prog)
0c8493d90b6bb0 Björn Töpel 2017-05-24 13421 bpf_prog_put(old_prog);
0c8493d90b6bb0 Björn Töpel 2017-05-24 13422
14ffeb52f3693a Magnus Karlsson 2019-01-29 13423 /* Kick start the NAPI context if there is an AF_XDP socket open
14ffeb52f3693a Magnus Karlsson 2019-01-29 13424 * on that queue id. This so that receiving will start.
14ffeb52f3693a Magnus Karlsson 2019-01-29 13425 */
599984216d420f Sylwester Dziedziuch 2022-12-21 13426 if (need_reinit && prog)
599984216d420f Sylwester Dziedziuch 2022-12-21 13427 i40e_vsi_rx_napi_schedule(vsi);
14ffeb52f3693a Magnus Karlsson 2019-01-29 13428
0c8493d90b6bb0 Björn Töpel 2017-05-24 13429 return 0;
599984216d420f Sylwester Dziedziuch 2022-12-21 13430
599984216d420f Sylwester Dziedziuch 2022-12-21 13431 err_setup_rx:
599984216d420f Sylwester Dziedziuch 2022-12-21 13432 i40e_vsi_free_rx_resources(vsi);
599984216d420f Sylwester Dziedziuch 2022-12-21 13433 err_setup_tx:
599984216d420f Sylwester Dziedziuch 2022-12-21 13434 i40e_vsi_free_tx_resources(vsi);
599984216d420f Sylwester Dziedziuch 2022-12-21 13435 err_vsi_setup:
599984216d420f Sylwester Dziedziuch 2022-12-21 13436 i40e_do_reset(pf, I40E_PF_RESET_FLAG, true);
599984216d420f Sylwester Dziedziuch 2022-12-21 13437 i40e_vsi_assign_bpf_prog(vsi, old_prog);
599984216d420f Sylwester Dziedziuch 2022-12-21 13438
599984216d420f Sylwester Dziedziuch 2022-12-21 13439 return ret;
0c8493d90b6bb0 Björn Töpel 2017-05-24 13440 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
reply other threads:[~2023-01-09 16:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202301090023.M6DN1R1S-lkp@intel.com \
--to=error27@gmail.com \
--cc=andrii.staikov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kamil.maziarz@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=sylwesterx.dziedziuch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox