From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1201C46467 for ; Thu, 19 Jan 2023 18:40:52 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 8353660FE5; Thu, 19 Jan 2023 18:40:52 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8353660FE5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1674153652; bh=O8bCxTeLOI/WdqC356JyjY16dc9ci0Z0XWNGo4MpI30=; h=Date:From:To:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:Cc:From; b=yS+mdK/CDLeVT4uN8pmtO1+UVvOaATLOWOAUH0IZrKqnYxgkoe19vY7VO87Ik1/6V cWntw/ZCQ3SHC9Nv7iS8KI9zO+yQZl7RYvCirZ+whqjvAvuc48R3Sapcadi61wWLea FKpV5aIAg0HjOuQ1GMI4jHErHDDGMMalAHnXieJ8LrtnSPO2kmFTs4REfHmMatyD6h QxKujXamGyf56RINrcK5Ws415RHb4ECDsrD1Z0WUuKb4phvzKvohlVEUGHND7YoO7i KMuQUdQ5viLX9AJrYTyyrJoVV/KWSzbd0bsjRMOlQQkcjr3BWmMyjdJmFulXGrfiaH B+jWC/niGOv6Q== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id r6sxtzmI7ipj; Thu, 19 Jan 2023 18:40:51 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 8C27861109; Thu, 19 Jan 2023 18:40:51 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 8C27861109 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 48E6C1BF33E for ; Thu, 19 Jan 2023 18:40:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 31471401AE for ; Thu, 19 Jan 2023 18:40:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 31471401AE X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id b5mG9KAaS-1h for ; Thu, 19 Jan 2023 18:40:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 7D343400CC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp2.osuosl.org (Postfix) with ESMTPS id 7D343400CC for ; Thu, 19 Jan 2023 18:40:48 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6DFB661D12; Thu, 19 Jan 2023 18:40:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5CD0C433D2; Thu, 19 Jan 2023 18:40:46 +0000 (UTC) Date: Thu, 19 Jan 2023 12:40:45 -0600 From: Bjorn Helgaas To: Tony Nguyen Message-ID: <20230119184045.GA482553@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4274cde6-3a64-e549-a833-3930732c756d@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674153646; bh=GheWbXSmySnzBphtK+e1BAQMhvFJrqswnLr0pq7sCks=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=tnKpcCZTqFBf8z9XQyNMTe6d/NvPOIR3jwBR9YtVK3zPAzFgJe52jb/gOmYWzRSt/ UN4WtvMYVHy1T7GpHbvTbZ+ACQAySX75cmiRbPii98b7s87tvDD/jypLJ4ikgW3WOf l/fQX4Ma+jh7Jnn14+bncoW8SiERq4OTZZTr0NNueZRheAwFrGP+r5kPXuoKG/2KBW dVipueMcE6lrix5cWeUzkadeIJRa7d2ZlU/8Rs1esGZBs3vHigUwnA9mT6ViKN7y2L nD8Dmk4HbnugSeN3Na9sPucu3RgLtlV3mWFtcgRZip8db+cY0yfUqjgGU2qyxhT4l8 Lxbp9YWPrFRGQ== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=tnKpcCZT Subject: Re: [Intel-wired-lan] [PATCH 2/9] e1000e: Remove redundant pci_enable_pcie_error_reporting() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sathyanarayanan Kuppuswamy , linux-pci@vger.kernel.org, Jesse Brandeburg , linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, Bjorn Helgaas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" [+cc Sathy] On Thu, Jan 19, 2023 at 10:28:16AM -0800, Tony Nguyen wrote: > On 1/18/2023 3:46 PM, Bjorn Helgaas wrote: > > From: Bjorn Helgaas > > > > pci_enable_pcie_error_reporting() enables the device to send ERR_* > > Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is > > native"), the PCI core does this for all devices during enumeration. > > > > Remove the redundant pci_enable_pcie_error_reporting() call from the > > driver. Also remove the corresponding pci_disable_pcie_error_reporting() > > from the driver .remove() path. > > > > Note that this doesn't control interrupt generation by the Root Port; that > > is controlled by the AER Root Error Command register, which is managed by > > the AER service driver. > > > > Signed-off-by: Bjorn Helgaas > > Cc: Jesse Brandeburg > > Cc: Tony Nguyen > > Cc: intel-wired-lan@lists.osuosl.org > > Cc: netdev@vger.kernel.org > > --- > > drivers/net/ethernet/intel/e1000e/netdev.c | 7 ------- > > 1 file changed, 7 deletions(-) > > Reviewed-by: Tony Nguyen Thanks a million for taking a look at these, Tony! These driver patches are all independent and have no dependency on the 1/9 PCI/AER patch. What's your opinion on merging these? Should they go via netdev? Should they be squashed into a single patch that does all the Intel drivers at once? I'm happy to squash them and/or merge them via the PCI tree, whatever is easiest. Bjorn _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan