From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34989C54E94 for ; Wed, 25 Jan 2023 19:02:34 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id C06C060C0E; Wed, 25 Jan 2023 19:02:33 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org C06C060C0E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1674673353; bh=KTrr1LiSAkGtuqSqueZID48bBsx/3KzDfYWp3POl4H0=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=ZNcNiI6H6xjepEKs19rBlactXyKM4i+PrTONR0uAGxuACc0rsNsSTmXw8cmrEAWuv O+/DPdo572sd+JVtzdVc481SqlkwWztHQlg3zAqz1LPVsgtBxVOfJxAO5UCdKOcjKo eDM0G5/jG9qsI1X8Kck8HOzNDTJbRE7OtlCVapB2H3bLOoew8e0wO6U3C2tEcDl/VS d7+lEQi9GewzOlhEJZj4j7G/BWcLDtYnvlBWGpDHGHl9v3trXjFX6rfELOg28YmQN9 ioDoNhEseo46vz4/9hBxaKVhh5N1R/Iulm4n5WhJK2FtkxTkyiRdAc8Ns474Vp0ha3 S/xsz0YJS2/nA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5vSG6hBrhocX; Wed, 25 Jan 2023 19:02:33 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id C927360D96; Wed, 25 Jan 2023 19:02:32 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org C927360D96 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 4F6551BF39D for ; Wed, 25 Jan 2023 19:02:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 281B841920 for ; Wed, 25 Jan 2023 19:02:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 281B841920 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7MFDqM39TrBR for ; Wed, 25 Jan 2023 19:02:30 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 72B9641833 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id 72B9641833 for ; Wed, 25 Jan 2023 19:02:30 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5AB24615C6; Wed, 25 Jan 2023 19:02:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8F3DC433D2; Wed, 25 Jan 2023 19:02:27 +0000 (UTC) Date: Wed, 25 Jan 2023 11:02:26 -0800 From: Jakub Kicinski To: Leon Romanovsky Message-ID: <20230125110226.66dc7eeb@kernel.org> In-Reply-To: References: MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674673348; bh=RP5Va6toXXyTmcOr/ME//AhDzcNFVNsgf8+hwufjGl0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OvZAxPfjKXDdktK4TkpLMXDuL4L107cdVVZ70PnwD568R3gI+0pb9bt8L790fN2cO 0EzUCDa6kkq9wiKJndJf4Ce6tFT6lhgwjkri5ihpOt5PBf3p67zOOvnwlXLab5eFiw uZz5SAcXwp6zfrhiZf/23QjiJL41EE2/yvMvIZlRFcS1aFtBfMB9pePhbuhwV2FK7R hQpP731ZhIaxFfP/jW1ElFNHHCWNw/avRemfV0YMNfl7cCLsdJEHKf/4DubkALGlhv kj8g0I5R7tiLa4hLJtPKkhQ2xpa25WBjEdydJD/flvD/WZ/xs/m4FQa5IQoWyJqlYh hCmuU/ozTe4xg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=OvZAxPfj Subject: Re: [Intel-wired-lan] [PATCH net-next v1 01/10] xfrm: extend add policy callback to set failure reason X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Steffen Klassert , Veaceslav Falico , Herbert Xu , Jonathan Corbet , Tony Nguyen , Jay Vosburgh , oss-drivers@corigine.com, linux-doc@vger.kernel.org, Raju Rangoju , Jesse Brandeburg , Eric Dumazet , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Ayush Sawal , Simon Horman , Saeed Mahameed , Paolo Abeni , Leon Romanovsky , "David S . Miller" , Andy Gospodarek Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, 24 Jan 2023 13:54:57 +0200 Leon Romanovsky wrote: > - err = dev->xfrmdev_ops->xdo_dev_policy_add(xp); > + err = dev->xfrmdev_ops->xdo_dev_policy_add(xp, extack); > if (err) { > xdo->dev = NULL; > xdo->real_dev = NULL; > xdo->type = XFRM_DEV_OFFLOAD_UNSPECIFIED; > xdo->dir = 0; > netdev_put(dev, &xdo->dev_tracker); > - NL_SET_ERR_MSG(extack, "Device failed to offload this policy"); In a handful of places we do: if (!extack->msg) NL_SET_ERR_MSG(extack, "Device failed to offload this policy"); in case the device did not provide the extack. Dunno if it's worth doing here. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan