Re: [Intel-wired-lan] [PATCH v2 bpf-next 2/8] drivers: net: turn on XDP features

From: kernel test robot <lkp@intel.com>
To: Lorenzo Bianconi <lorenzo@kernel.org>, bpf@vger.kernel.org
Cc: mst@redhat.com, vladimir.oltean@nxp.com, john@phrozen.org,
	ast@kernel.org, edumazet@google.com, anthony.l.nguyen@intel.com,
	daniel@iogearbox.net, andrii@kernel.org,
	intel-wired-lan@lists.osuosl.org, simon.horman@corigine.com,
	kuba@kernel.org, pabeni@redhat.com, aelior@marvell.com,
	hawk@kernel.org, christophe.jaillet@wanadoo.fr, memxor@gmail.com,
	oe-kbuild-all@lists.linux.dev, bjorn@kernel.org,
	magnus.karlsson@intel.com, leon@kernel.org,
	netdev@vger.kernel.org, toke@redhat.com, ecree.xilinx@gmail.com,
	alardam@gmail.com, gospo@broadcom.com, saeedm@nvidia.com,
	davem@davemloft.net, nbd@nbd.name
Subject: Re: [Intel-wired-lan] [PATCH v2 bpf-next 2/8] drivers: net: turn on XDP features
Date: Wed, 25 Jan 2023 12:00:19 +0800	[thread overview]
Message-ID: <202301251150.xzkLwNpI-lkp@intel.com> (raw)
In-Reply-To: <c1171111f8af76da11331277b1e4a930c10f3c30.1674606197.git.lorenzo@kernel.org>

Hi Lorenzo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Lorenzo-Bianconi/netdev-genl-create-a-simple-family-for-netdev-stuff/20230125-083645
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link:    https://lore.kernel.org/r/c1171111f8af76da11331277b1e4a930c10f3c30.1674606197.git.lorenzo%40kernel.org
patch subject: [PATCH v2 bpf-next 2/8] drivers: net: turn on XDP features
config: arc-defconfig (https://download.01.org/0day-ci/archive/20230125/202301251150.xzkLwNpI-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/7dab4c7d96218eccccedd50e72c84e0ef4de0f4a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Lorenzo-Bianconi/netdev-genl-create-a-simple-family-for-netdev-stuff/20230125-083645
        git checkout 7dab4c7d96218eccccedd50e72c84e0ef4de0f4a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> net/core/xdp.c:777:6: error: redefinition of 'xdp_features_set_redirect_target'
     777 | void xdp_features_set_redirect_target(struct net_device *dev, bool support_sg)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   In file included from include/linux/netdevice.h:43,
                    from include/linux/if_vlan.h:10,
                    from include/linux/filter.h:20,
                    from net/core/xdp.c:8:
   include/net/xdp.h:418:1: note: previous definition of 'xdp_features_set_redirect_target' with type 'void(struct net_device *, bool)' {aka 'void(struct net_device *, _Bool)'}
     418 | xdp_features_set_redirect_target(struct net_device *dev, bool support_sg)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> net/core/xdp.c:787:6: error: redefinition of 'xdp_features_clear_redirect_target'
     787 | void xdp_features_clear_redirect_target(struct net_device *dev)
         |      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/net/xdp.h:423:1: note: previous definition of 'xdp_features_clear_redirect_target' with type 'void(struct net_device *)'
     423 | xdp_features_clear_redirect_target(struct net_device *dev)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

vim +/xdp_features_set_redirect_target +777 net/core/xdp.c

   776	
 > 777	void xdp_features_set_redirect_target(struct net_device *dev, bool support_sg)
   778	{
   779		dev->xdp_features |= NETDEV_XDP_ACT_NDO_XMIT;
   780		if (support_sg)
   781			dev->xdp_features |= NETDEV_XDP_ACT_NDO_XMIT_SG;
   782	
   783		call_netdevice_notifiers(NETDEV_XDP_FEAT_CHANGE, dev);
   784	}
   785	EXPORT_SYMBOL_GPL(xdp_features_set_redirect_target);
   786	
 > 787	void xdp_features_clear_redirect_target(struct net_device *dev)

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan