From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3AB3BC05027 for ; Thu, 26 Jan 2023 23:15:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id AA48040423; Thu, 26 Jan 2023 23:15:34 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org AA48040423 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1674774934; bh=aEuJ2z+Z7lDKwtrZlAo946K03fFCyY2rVQgI6K3CjAg=; h=Date:From:To:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:Cc:From; b=F8yBDDZ+I0vLeRKHYqNmbYZZsx7DVUfkYlCA39rLt2xhuQ+1w4F1KPH5Dm3rNhnQF qvcLuNa9GjUKbCq5yoAc+odPWtFr1xyBBi0k51KowdFOkVBouB+aQE5Z0WLsXrQ2Ml La2VpJ0oTtJELWE36qTHsg1Zvym6eQgTxo/h/rS52rOcQ1iGlnVw8/Cx0lcZok5Kkx vfBAhr99XFjHGfq7ipcbMBrf37D21NvFRHlmERwKHUyiUOXo3CF27aNlQgbUPfPwHJ VbRoP/Kugl105mrtyz9MHOqObiRReqXPGhwTgfZHZoccATcZrXbgMjGMHwIEMmeZX+ /z4TBKVbwZNqg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2-inB2v2yMOw; Thu, 26 Jan 2023 23:15:33 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 9931F4057C; Thu, 26 Jan 2023 23:15:33 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 9931F4057C Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 77D301BF2F8 for ; Thu, 26 Jan 2023 23:15:31 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5C7DE611D1 for ; Thu, 26 Jan 2023 23:15:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5C7DE611D1 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YvrqQqylsJDa for ; Thu, 26 Jan 2023 23:15:30 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org AD0CE6118B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp3.osuosl.org (Postfix) with ESMTPS id AD0CE6118B for ; Thu, 26 Jan 2023 23:15:30 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 989396199C; Thu, 26 Jan 2023 23:15:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B504CC433EF; Thu, 26 Jan 2023 23:15:28 +0000 (UTC) Date: Thu, 26 Jan 2023 17:15:27 -0600 From: Bjorn Helgaas To: linux-pci@vger.kernel.org Message-ID: <20230126231527.GA1322015@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230118234612.272916-1-helgaas@kernel.org> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674774929; bh=yLxfhl2XeMsnGXh8m4CYuImOEZKgrEUslX63nDnPLrc=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=VPk1P6ShqdMJdgOLDXfAg3hmy8SL4IAesCX9ibxD3BDdaupVSCJa7vRBe9x1k72s3 0WT3de7uDz1Kh7XfvLBViNk61oDrsMXN3jDJ09HhctMhpqHlfJ81OdtfBE+PohHfd4 tw+89BwTzSlRTG8QDGtuRInId/FBPYFZd6NTyYImd89YX/3OfczFjJj4qstBXsQrRh 9Ede9P3N6bh8AVRHs4Hg7Qyumb+wJn3pVA0l3XyLzekrglV+HU1C6A/7KeCFZypUD2 XMOBOd5CEzMzRNhi3tlSuHqf1WLHI2Os2wURhy0PtV93Cg6KqWu3qHavIsmPzpQGf+ GH4IkWzOisVbQ== X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=VPk1P6Sh Subject: Re: [Intel-wired-lan] [PATCH 0/9] PCI/AER: Remove redundant Device Control Error Reporting Enable X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sathyanarayanan Kuppuswamy , Ashok Raj , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jesse Brandeburg , Keith Busch , Tony Nguyen , Jakub Kicinski , Bjorn Helgaas , intel-wired-lan@lists.osuosl.org, Stefan Roese Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" [+cc all the folks I forgot to cc when sending the original cover letter, sorry about that, plus the folks who very generously tested the driver patches] On Wed, Jan 18, 2023 at 05:46:03PM -0600, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is native"), > ths PCI core sets the Device Control bits that enable error reporting for > PCIe devices. > > This series removes redundant calls to pci_enable_pcie_error_reporting() > that do the same thing from the AER driver and several NIC drivers. > > There are several more drivers where this should be removed; I started with > just the Intel drivers here. > > Bjorn Helgaas (9): > PCI/AER: Remove redundant Device Control Error Reporting Enable > e1000e: Remove redundant pci_enable_pcie_error_reporting() > fm10k: Remove redundant pci_enable_pcie_error_reporting() > i40e: Remove redundant pci_enable_pcie_error_reporting() > iavf: Remove redundant pci_enable_pcie_error_reporting() > ice: Remove redundant pci_enable_pcie_error_reporting() > igb: Remove redundant pci_enable_pcie_error_reporting() > igc: Remove redundant pci_enable_pcie_error_reporting() > ixgbe: Remove redundant pci_enable_pcie_error_reporting() Thank you very much for reviewing and testing these. I applied the first (PCI/AER) patch to the PCI tree. I think Jakub is planning to merge the rest via the netdev tree. There are no dependencies, so they can be squashed if desired. Let me know if you'd prefer me to merge them or squash them. > drivers/net/ethernet/intel/e1000e/netdev.c | 7 --- > drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 5 -- > drivers/net/ethernet/intel/i40e/i40e_main.c | 4 -- > drivers/net/ethernet/intel/iavf/iavf_main.c | 5 -- > drivers/net/ethernet/intel/ice/ice_main.c | 3 -- > drivers/net/ethernet/intel/igb/igb_main.c | 5 -- > drivers/net/ethernet/intel/igc/igc_main.c | 5 -- > drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 5 -- > drivers/pci/pcie/aer.c | 48 ------------------- > 9 files changed, 87 deletions(-) > > -- > 2.25.1 > _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan