From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45C69C636D3 for ; Mon, 6 Feb 2023 16:29:11 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id CC82D400D0; Mon, 6 Feb 2023 16:29:10 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org CC82D400D0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1675700950; bh=R/51twfR5Mmh68OrzN4ty3ILMiZnx+JL1iwXXhfcyVI=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=rbQjY1X98QcPu0BC+8I96NhpH3pUBW53j6WxUSwh4wXRXQ7OoGHLQrUdPxOMF+iXI NXdWgYfq0EqW7kGJ8524ruL+h92nJYsPy3vq4sHcS4yPJ5k4KOMMhgxulg5CCyj4zJ LU79zN5Zu9wrFbLxA7uNDn/e3QOEY404652d+zES3ioV4uKyzXI5B9EphRmFjA+7QJ MaJ+8i4E6hmBpyw2133Syq4f/4A15PZS+C7R2xQGOI8aBfCTvLnEHkhFfQkr9+BD2c SE1wlwwg9L/Tr9GiuoJNdyM5dBnCQ+cgLP0YkJXq5Fvjndwj4D5KkVBIv/oeb75gsu YeZoy7m6I9nRQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XRuY82pKOm6R; Mon, 6 Feb 2023 16:29:10 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id B9DAC403AC; Mon, 6 Feb 2023 16:29:09 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org B9DAC403AC Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 99FD91BF2CF for ; Mon, 6 Feb 2023 10:50:22 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 730364031D for ; Mon, 6 Feb 2023 10:50:22 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 730364031D X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z-CSiv0oQ3JB for ; Mon, 6 Feb 2023 10:50:21 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 1D666402EB Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by smtp2.osuosl.org (Postfix) with ESMTPS id 1D666402EB for ; Mon, 6 Feb 2023 10:50:21 +0000 (UTC) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pOz4P-0004HP-Jh; Mon, 06 Feb 2023 11:49:57 +0100 Received: from ore by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pOz4N-0006lC-3o; Mon, 06 Feb 2023 11:49:55 +0100 Date: Mon, 6 Feb 2023 11:49:55 +0100 From: Oleksij Rempel To: Vladimir Oltean Message-ID: <20230206104955.GE12366@pengutronix.de> References: <20230201145845.2312060-1-o.rempel@pengutronix.de> <20230201145845.2312060-3-o.rempel@pengutronix.de> <20230204005418.7ryb4ihuzxlbs2nl@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230204005418.7ryb4ihuzxlbs2nl@skbuf> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: intel-wired-lan@lists.osuosl.org X-Mailman-Approved-At: Mon, 06 Feb 2023 16:29:04 +0000 Subject: Re: [Intel-wired-lan] [PATCH net-next v4 02/23] net: phy: add genphy_c45_read_eee_abilities() function X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Woojung Huh , Andrew Lunn , Arun.Ramadoss@microchip.com, Florian Fainelli , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vivien Didelot , Eric Dumazet , Paolo Abeni , Wei Fang , kernel@pengutronix.de, intel-wired-lan@lists.osuosl.org, Jakub Kicinski , UNGLinuxDriver@microchip.com, "David S. Miller" , Heiner Kallweit Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Hi Vladimir, On Sat, Feb 04, 2023 at 02:54:18AM +0200, Vladimir Oltean wrote: > On Wed, Feb 01, 2023 at 03:58:24PM +0100, Oleksij Rempel wrote: [....] > > +static const int phy_eee_100_10000_features_array[6] = { > > Don't need array length unless the array is sparse, which isn't the case here. > > > + ETHTOOL_LINK_MODE_100baseT_Full_BIT, > > + ETHTOOL_LINK_MODE_1000baseT_Full_BIT, > > + ETHTOOL_LINK_MODE_10000baseT_Full_BIT, > > + ETHTOOL_LINK_MODE_1000baseKX_Full_BIT, > > + ETHTOOL_LINK_MODE_10000baseKX4_Full_BIT, > > + ETHTOOL_LINK_MODE_10000baseKR_Full_BIT, > > Why stop at 10GBase-KR? Register 3.20 defines EEE abilities up to 100G > (for speeds >10G, there seem to be 2 modes, "deep sleep" or "fast wake", > with "deep sleep" being essentially equivalent to the only mode > available for <=10G modes). Hm, If i take only deep sleep, missing modes are: 3.20.13 100GBASE-R deep sleep family of Physical Layer devices using 100GBASE-R encoding: 100000baseCR4_Full 100000baseKR4_Full 100000baseCR10_Full (missing) 100000baseSR4_Full 100000baseSR10_Full (missing) 100000baseLR4_ER4_Full 3.20.11 25GBASE-R deep sleep family of Physical Layer devices using 25GBASE-R encoding: 25000baseCR_Full 25000baseER_Full (missing) 25000baseKR_Full 25000baseLR_Full (missing) 25000baseSR_Full 3.20.9 40GBASE-R deep sleep family of Physical Layer devices using 40GBASE-R encoding: 40000baseKR4_Full 40000baseCR4_Full 40000baseSR4_Full 40000baseLR4_Full 3.20.7 40GBASE-T 40000baseT_Full (missing) I have no experience with modes > 1Gbit. Do all of them correct? What should we do with missing modes? Or may be it make sense to implement > 10G modes separately? Regards, Oleksij -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan