From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1EC9C77B72 for ; Thu, 20 Apr 2023 14:59:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 5F09F61042; Thu, 20 Apr 2023 14:59:49 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5F09F61042 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1682002789; bh=dBjtazc71Qi9wicOZfQVrhpK4Kek6YB1apUJjcnq3iM=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=kvbCBHZYXRP0GCbzEOTPwwzktb+EawCcOutNmla517/rx+iXmfdRvUrc3DCa00HmS 8V8V9PYzK9Lt91EoMnJP+aJeE92KNUFxuQQyOKFaBTBWVe6SXsqHCAmQ/xV83iGcm7 /dqr0vu3SXgUSeInuTLc9+npPOdyBq/409F+rCXVVyf5YTzGUnEq5zGWMqq7SrrUf3 2bcrmr69eTU6HXABHnIvw+zM7dM1dtSI0z1dRlx5ryPz5NXpsTuZYV1tDpbEmK5YKT j8d2etPSchLV6H0zNV+Y7A96g5QnY/zrjnig3+GPnk03mfs1fBtXpeKPmhrEu31S63 lcTKs7NuuUG0w== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jAwYmEN4Qoju; Thu, 20 Apr 2023 14:59:48 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id 891706FF08; Thu, 20 Apr 2023 14:59:48 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 891706FF08 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id EAC5F1BF2CD for ; Thu, 20 Apr 2023 14:59:46 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BC5A3418CF for ; Thu, 20 Apr 2023 14:59:46 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org BC5A3418CF X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Av1NyQ4MIn2Z for ; Thu, 20 Apr 2023 14:59:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 026CB41866 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp4.osuosl.org (Postfix) with ESMTPS id 026CB41866 for ; Thu, 20 Apr 2023 14:59:45 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E8BFF64A1C; Thu, 20 Apr 2023 14:59:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30528C433EF; Thu, 20 Apr 2023 14:59:44 +0000 (UTC) Date: Thu, 20 Apr 2023 07:59:43 -0700 From: Jakub Kicinski To: Alexander Lobakin Message-ID: <20230420075943.4ef9b68a@kernel.org> In-Reply-To: <21b89328-8c74-596b-3cfe-e71affd193a8@intel.com> References: <20230419231751.11581-1-ahmed.zaki@intel.com> <21b89328-8c74-596b-3cfe-e71affd193a8@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682002784; bh=/D8ISpki4l1J4whygb9ubLZyEG1f518zP3ZWZthbXPA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RNU4vKpt3/KIphM9zbptyAkV4k9sjA9q/cCcr3KgQi6jsSx4BLqR/gvbZeQJ+MCqH 4nxXQ1/wlpVHSEBnHh7JAVV3Trcb6OmzGZwFaabVOG/wuzPvPZSKhds64WeB0cdxUn ie9rnvvJtx4cJw/bbhm75O8x17oWvAbtjtvQy3e37xwCEzvtzEAYLOOc6j1IUKisv9 TtUvoFgvxmfaeHqKKjT0d+toQp5kIXbpraeDF2WGjLuqftkI2hQ1bC0YOwUJznTFaY Ji9TJ12/DhsxqeoLASnjW17MKyeTGOfI8bZuc9uAPWM+mGf9KwObfVQSoJqT6Qc1HA 6cyv+ycDFrEIQ== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=RNU4vKpt Subject: Re: [Intel-wired-lan] [PATCH net-next] iavf: remove double underscores from states names X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "netdev@vger.kernel.org" , intel-wired-lan@lists.osuosl.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, 20 Apr 2023 16:33:54 +0200 Alexander Lobakin wrote: > > No need to prepend some states names with "__", especially that others do > > not have these underscores. > > What's the value of this change, apart from 400 locs diffstat? I don't > say having prefixes for general-purpose definitions is correct, but... > Dunno. Would be nice to have as a part of some series with assorted > improvements, but not standalone. Or it's just me =\ Yeah, I'm not sure it's bad enough to justify the code churn, either. Up to you folks at Intel. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan