From: Prasad Koya <prasad@arista.com>
To: intel-wired-lan@lists.osuosl.org
Cc: Devora Fuxbrumer <devora.fuxbrumer@intel.com>,
Salam Noureddine <noureddine@arista.com>,
Anthony L Nguyen <anthony.l.nguyen@intel.com>,
Bob Gilligan <gilligan@arista.com>,
Dima Ruinskiy <dima.ruinskiy@intel.com>,
Amir Avivi <amir.avivi@intel.com>,
Prasad Koya <prasad@arista.com>
Subject: [Intel-wired-lan] [PATCH] [iwl-net, v2] igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings
Date: Sun, 4 Jun 2023 20:15:34 -0700 [thread overview]
Message-ID: <20230605031534.9846-1-prasad@arista.com> (raw)
set TP bit in the 'supported' and 'advertising' fields. I226 only supports twisted pair copper.
Fixes: 8c5ad0dae93c9 ("igc: Add ethtool support")
Signed-off-by: Prasad Koya <prasad@arista.com>
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index 8cc077b712ad..511fc3f41208 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -1707,6 +1707,8 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
/* twisted pair */
cmd->base.port = PORT_TP;
cmd->base.phy_address = hw->phy.addr;
+ ethtool_link_ksettings_add_link_mode(cmd, supported, TP);
+ ethtool_link_ksettings_add_link_mode(cmd, advertising, TP);
/* advertising link modes */
if (hw->phy.autoneg_advertised & ADVERTISE_10_HALF)
--
2.25.1
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next reply other threads:[~2023-06-05 15:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 3:15 Prasad Koya [this message]
2023-06-05 8:34 ` [Intel-wired-lan] [PATCH] [iwl-net, v2] igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings Neftin, Sasha
2023-06-05 17:05 ` Paul Menzel
2023-06-05 18:11 ` Prasad Koya
2023-06-21 9:23 ` naamax.meir
-- strict thread matches above, loose matches on Subject: below --
2023-06-05 18:09 Prasad Koya
2023-06-21 9:26 ` naamax.meir
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605031534.9846-1-prasad@arista.com \
--to=prasad@arista.com \
--cc=amir.avivi@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=devora.fuxbrumer@intel.com \
--cc=dima.ruinskiy@intel.com \
--cc=gilligan@arista.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=noureddine@arista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox