From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A841EB64D0 for ; Tue, 13 Jun 2023 18:24:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E5B48405A2; Tue, 13 Jun 2023 18:24:42 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org E5B48405A2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1686680682; bh=YNwHxO9MT+aXohHQLxV6k3H05pzKNORPDysgNtcyXJ0=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=Hv6leZyX7e05fhXwsm7CVnS/7nIFFhr0S50R+xodJDurLVtv9EIisE8nSAJwzUqCr HaPGaquP2sXWUhzP0pNIr8Um/Ph9Rhdc4hSFSSr8KpT/+x+m4k2r9P6RmsiqD51xzn OYjj6ILaUKAzmtrXI9ng8tgrVSNVVy/5fA/jDs+UGS8p8AwJ3KuuzlglDb50oGpHyJ k+5fYKAWhW/vWBUk9KBsFgjpCzYaB5QgVyIzekYSqR0alDSnbLl5TJVfD50XuiTZzW qS3AC/l6fPXVABzQKROv86OlneMxvdj5qeWTb2aH/N+zv+gV5/zaUHYBifqg8wYp/x F5SVxk/Pxur2g== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bopunkSquKZd; Tue, 13 Jun 2023 18:24:41 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id A16904052A; Tue, 13 Jun 2023 18:24:41 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A16904052A Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 5E4321BF34B for ; Tue, 13 Jun 2023 18:24:39 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 359C64052A for ; Tue, 13 Jun 2023 18:24:39 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 359C64052A X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KHsd82cZzu6Z for ; Tue, 13 Jun 2023 18:24:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 6315F400BF Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp2.osuosl.org (Postfix) with ESMTPS id 6315F400BF for ; Tue, 13 Jun 2023 18:24:38 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BAFA561ED8; Tue, 13 Jun 2023 18:24:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC6ADC433D9; Tue, 13 Jun 2023 18:24:36 +0000 (UTC) Date: Tue, 13 Jun 2023 11:24:35 -0700 From: Jakub Kicinski To: Piotr Gardocki Message-ID: <20230613112435.18dc8130@kernel.org> In-Reply-To: <9ea8a985-923d-62ec-5a34-ef7eeb056f05@intel.com> References: <20230613122420.855486-1-piotrx.gardocki@intel.com> <20230613122420.855486-4-piotrx.gardocki@intel.com> <4db2d627-782c-90c2-4826-76b9779149ce@intel.com> <837ccaeb-a77d-5570-1363-e5e344528f97@intel.com> <08b11944-984f-eeeb-4b03-777faaa3ce01@intel.com> <9ea8a985-923d-62ec-5a34-ef7eeb056f05@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686680677; bh=A005nyPSR9jUxTXYuLs+acV5N0eBgSvqxWNwQk/+X+s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pPYkCBz6dfGob5Odf1vnwK7Fvz8kgt3dGA/BrjEJZU0hVWQvfLEm5yVHc7b9DuQWl igVUgkwfDV52ZKOoQ1qrVXhLN0LkUUMtbS/GfUm4ANYJaZaEKxsW9jJUP8Qs/LxS3H C284kHAhdYN5RqH5fKzonoM2hMYe//DuZho3O6vOlaq+kiT+wmsWl2yyKlhbT2EEMA t/TFLizi9ZzbAkH6EUsgqU05/4dbs8oBeJ7w4ki1ffl5rTDLQAZwHDH2yqySE3UySW EPcbcKse1V9S3aHSyDHi3IsRit7unQyMLqGetOFJ+XN0iL854AjKUUNQwGZEoQm/TU DQk4mBpK4Yb6g== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=pPYkCBz6 Subject: Re: [Intel-wired-lan] [PATCH net-next v2 3/3] ice: remove unnecessary check for old MAC == new MAC X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pmenzel@molgen.mpg.de, simon.horman@corigine.com, netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Przemek Kitszel , anthony.l.nguyen@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Tue, 13 Jun 2023 17:32:50 +0200 Piotr Gardocki wrote: > > there is ether_addr_equal() call in iavf_set_mac(), even if not > > exactly before eth_hw_addr_set(), it still should be removed ;) > > > > Anyway, I would fix all 3 drivers with one patch. > > I guess you're looking at old version of dev-queue branch on Tony's > tree :) Regarding ice and i40e I made two patches to have different > prefixes in titles. I don't mind merging them, but I'll wait for > someone else speaking up about this. I think the series is good enough, FWIW. We're already at -rc6, seems more important to give syzbot and testers time to exercise the core change than fishing out more drivers. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan