From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1E36C7EE2E for ; Tue, 13 Jun 2023 12:24:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 7A0654063D; Tue, 13 Jun 2023 12:24:47 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 7A0654063D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1686659087; bh=9y/9GsKY6zjS+HqsnUsUt/ybJ2BEWiVGFHC1IhSbnIw=; h=From:To:Date:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=oUthVtI9UecZuH7BqHaeBZVMYlIyBzxPGby04bj2wxORiE383A3ISQ2ROE65pvHi4 QyRR9RU/nsPTNPT605fmF19R30kafveHy1rLyE5ScWtJe9Q384dl5m7jqEEFllQaJB 3HfHCDEmuBzuSgC2uKtyFFVOWtEnEv6rRePgMTSmrEFf6o1VleFpBlzGONCyRNDNLS lgLpDzjj2G071ZVL0Sp8t0KGIS4lkD6dehG73MLax8XQdJXZRl/Ttm7N1jC48WPSxo Kc2aPm6LL8QjBE/HwQ9Q0iWTdnt7LE6lygpt8dgiqOGDhpJqgjn5QeGmrZyTbRBe8d dcj9uXLSpwr8g== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hkd8fZ2F9lWx; Tue, 13 Jun 2023 12:24:45 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 15301416E3; Tue, 13 Jun 2023 12:24:45 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 15301416E3 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id C05E01BF352 for ; Tue, 13 Jun 2023 12:24:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id A7228822C7 for ; Tue, 13 Jun 2023 12:24:38 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org A7228822C7 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ouD3DCXFWWNm for ; Tue, 13 Jun 2023 12:24:38 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org F04BB8214C Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by smtp1.osuosl.org (Postfix) with ESMTPS id F04BB8214C for ; Tue, 13 Jun 2023 12:24:37 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="337951237" X-IronPort-AV: E=Sophos;i="6.00,239,1681196400"; d="scan'208";a="337951237" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2023 05:24:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="835872008" X-IronPort-AV: E=Sophos;i="6.00,239,1681196400"; d="scan'208";a="835872008" Received: from pgardocx-mobl1.igk.intel.com ([10.237.95.41]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jun 2023 05:24:34 -0700 From: Piotr Gardocki To: netdev@vger.kernel.org Date: Tue, 13 Jun 2023 14:24:20 +0200 Message-Id: <20230613122420.855486-4-piotrx.gardocki@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230613122420.855486-1-piotrx.gardocki@intel.com> References: <20230613122420.855486-1-piotrx.gardocki@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686659077; x=1718195077; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aiy2x7WzA9Zv0AUyWsyvj/l73+iJBj7g8yRezUPEHv4=; b=N2ermxKc7hpA2JFa9qmCTuTtAYC+jCk0KJV0jHm1EB6EZioydplLP0Zx p2M+MFOV4mIv/LqPaV1R60HY0neARk0/CDtTxgio0p70PL1FJBYQuMrRH A0CwS84kdU4E5qFUqJZ2gK/E/tpj2k4xmPuW0793WBrYNe9EZ1AFHAxnB ejI9S8v7oaneu+CWrQnLThlWYfVpP4zTXfKtsskTx9r6+J3HNov2Z19Ri FmCCL8iNPavF4LblRQz1DEaQbgkwZi7S9qW+CuKKN10I6T2Yicgi0BJCX oW421h8W9rl0ujKCaVJbwq+7ZMIteFUTThXYe7foFSDcFJgpAluuAcBmg g==; X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=N2ermxKc Subject: [Intel-wired-lan] [PATCH net-next v2 3/3] ice: remove unnecessary check for old MAC == new MAC X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pmenzel@molgen.mpg.de, przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org, simon.horman@corigine.com, kuba@kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" The check has been moved to core. The ndo_set_mac_address callback is not being called with new MAC address equal to the old one anymore. Signed-off-by: Piotr Gardocki --- drivers/net/ethernet/intel/ice/ice_main.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c index caafb12d9cc7..f0ba896a3f46 100644 --- a/drivers/net/ethernet/intel/ice/ice_main.c +++ b/drivers/net/ethernet/intel/ice/ice_main.c @@ -5624,11 +5624,6 @@ static int ice_set_mac_address(struct net_device *netdev, void *pi) if (!is_valid_ether_addr(mac)) return -EADDRNOTAVAIL; - if (ether_addr_equal(netdev->dev_addr, mac)) { - netdev_dbg(netdev, "already using mac %pM\n", mac); - return 0; - } - if (test_bit(ICE_DOWN, pf->state) || ice_is_reset_in_progress(pf->state)) { netdev_err(netdev, "can't set mac %pM. device not ready\n", -- 2.34.1 _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan