From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@intel.com>
Cc: "tee.min.tan@linux.intel.com" <tee.min.tan@linux.intel.com>,
"intel-wired-lan@osuosl.org" <intel-wired-lan@osuosl.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v3] igc: Add TransmissionOverrun counter
Date: Tue, 13 Jun 2023 18:41:22 +0300 [thread overview]
Message-ID: <20230613154122.d75fclckvwxlapwi@skbuf> (raw)
In-Reply-To: <SJ1PR11MB618092B287B39503DD2C5873B855A@SJ1PR11MB6180.namprd11.prod.outlook.com>
On Tue, Jun 13, 2023 at 03:38:54PM +0000, Zulkifli, Muhammad Husaini wrote:
> No, they aren't aware of it. They will just query this counter to determine if the
> value has increased or not. The test plan does not rely entirely on the counter.
> On the receive side, it will validate all frames for the traffic class involved.
> Any transmitted frame that is not received or any of the received frame
> does not fulfil the frameEndTime criteria will cause the test plan to fail before
> reading the overrun counter again. Since our HW with STRICT_END bit able to
> fulfill the criteria, we can assume that Counter "0" is valid here.
>
> Unless HW fails to meet the framEndtime criteria and reports a "0" value...
> However, in this scenario, it will eventually fail the test plan.
Ok, I take back this objection then, only the other one remains in that
case, with unnecessarily keeping this constant counter in the driver's
ring data structures.
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-06-13 15:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 0:59 [Intel-wired-lan] [PATCH iwl-net v3] igc: Add TransmissionOverrun counter Muhammad Husaini Zulkifli
2023-06-01 1:29 ` Zulkifli, Muhammad Husaini
2023-06-06 14:02 ` Vladimir Oltean
2023-06-09 17:10 ` Zulkifli, Muhammad Husaini
2023-06-09 17:38 ` Vladimir Oltean
2023-06-12 3:50 ` Zulkifli, Muhammad Husaini
2023-06-12 14:28 ` Vladimir Oltean
2023-06-13 15:38 ` Zulkifli, Muhammad Husaini
2023-06-13 15:41 ` Vladimir Oltean [this message]
2023-06-14 1:07 ` Zulkifli, Muhammad Husaini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230613154122.d75fclckvwxlapwi@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@osuosl.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=tee.min.tan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox