From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F289EB64DC for ; Tue, 20 Jun 2023 08:25:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 2452860E6F; Tue, 20 Jun 2023 08:25:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2452860E6F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1687249508; bh=lIJMDR9ZUeb8AEPRgA4e+MwEoSyUXLSsm/OAePaBYY8=; h=From:To:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:Cc:From; b=JYwIpsSJqDZPtV+5SeAtCPVcRtpBu5CsIwWxEK4cEFvmAQYy8nURh3a1C+cZwkXiT z4bS9twc/U5T0YaE0zwhTBoQWVuTdsuwOLD85C5jGqbk0FxincQcds5FQ2QAHFT0YB IBW3YUBSYibKhVmr01IMFljhWqnVB7/E8ZuTcQFPLqz+yGfYfQyMBM4w31llST9sV9 Gu2K6h/BSjo1SApGyLAYS3qAN/JtIlS/FxHIVbSvHeMjCIRzPCEikRV7LYGQrS9Em4 E0XllHK42OKaUU/obAF5omP8X9Jtosb98axssnwzHPp3kDh5BV02i+maRTWnh6wyyZ YVx8iwZn7Z3FA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aMTUymemNdPA; Tue, 20 Jun 2023 08:25:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp3.osuosl.org (Postfix) with ESMTP id F32BD60F26; Tue, 20 Jun 2023 08:25:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org F32BD60F26 Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id BB99D1BF3C3 for ; Tue, 20 Jun 2023 08:25:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 902F760E6F for ; Tue, 20 Jun 2023 08:25:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 902F760E6F X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dCQpPvGWkpJJ for ; Tue, 20 Jun 2023 08:25:03 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org D289160D59 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by smtp3.osuosl.org (Postfix) with ESMTPS id D289160D59 for ; Tue, 20 Jun 2023 08:25:02 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="357287944" X-IronPort-AV: E=Sophos;i="6.00,256,1681196400"; d="scan'208";a="357287944" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 01:25:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10746"; a="691346033" X-IronPort-AV: E=Sophos;i="6.00,256,1681196400"; d="scan'208";a="691346033" Received: from boxer.igk.intel.com ([10.102.20.173]) by orsmga006.jf.intel.com with ESMTP; 20 Jun 2023 01:25:00 -0700 From: Maciej Fijalkowski To: intel-wired-lan@lists.osuosl.org Date: Tue, 20 Jun 2023 10:24:54 +0200 Message-Id: <20230620082454.377001-1-maciej.fijalkowski@intel.com> X-Mailer: git-send-email 2.35.3 MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687249502; x=1718785502; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=iAVElBJATHHVS8jixdg/1VEQURYFyFA0PaU7QYlOOmg=; b=mejPJxdPKLNdFSfQI/3rOCF5TcjASyZjKfzm3Meirjdi6gcblEn9x9FR CyHrXHhMZme6TaGEcp1jZiO5B2exjOtqKOfP+8AhVN1VafzA2WczRYvfb 9I93aJZGTmJiube2cVYlh8cNnp+yDfUTtZPvSKu6wzQABt9hghxy83i40 IBRia/Vq6XloNORrJgk3aGo53ZIzzf4Wk7DM5DKwOd3Bp04jBuL0rl+GA 7SNcpLwJ9lkC6l8CkpoqQ2ccahSNlW1eGqZXqd+0cAk0EuhQeQW2gF5lI K7D7T84dPHNiH0lboDTzAZpfxyDyucVgGDTzYHzccH+S+4N5V4gle2/by Q==; X-Mailman-Original-Authentication-Results: smtp3.osuosl.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=mejPJxdP Subject: [Intel-wired-lan] [PATCH iwl-net] ice: add missing napi deletion X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, anthony.l.nguyen@intel.com, magnus.karlsson@intel.com, michal.swiatkowski@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Error path from ice_probe() is missing ice_napi_del() calls, add it to ice_deinit_eth() as ice_init_eth() was the one to add napi instances. It is also a good habit to delete napis when removing driver and this also addresses that. FWIW ice_napi_del() had no callsites. Fixes: 6624e780a577 ("ice: split ice_vsi_setup into smaller functions") Signed-off-by: Maciej Fijalkowski --- drivers/net/ethernet/intel/ice/ice_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c index cd562856f23a..f6b041490154 100644 --- a/drivers/net/ethernet/intel/ice/ice_main.c +++ b/drivers/net/ethernet/intel/ice/ice_main.c @@ -4485,6 +4485,7 @@ static void ice_deinit_eth(struct ice_pf *pf) if (!vsi) return; + ice_napi_del(vsi); ice_vsi_close(vsi); ice_unregister_netdev(vsi); ice_devlink_destroy_pf_port(pf); -- 2.34.1 _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan