From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7C50BC83F10 for ; Sat, 26 Aug 2023 00:55:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0F4CE83C8B; Sat, 26 Aug 2023 00:55:03 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 0F4CE83C8B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1693011303; bh=wXTQik1L5kMne2cRhLMvf3rXf9/TnkWfuq07qRHSIr0=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=VnymiIm0pM21JCY1JXJz4VzGk4UF1yPMnQt0Wc8r+BaMce7ZKdPEMVMaEvLqncLeo 047RgCs6ctfG6ygCyZYrl6atKGbrxHPeKD9ysgUeTzSopspRVhAF2xWouy+9KEoJAx tRolXpk+/U2jYr3akIvCOmIAAtZHD8bu/Lgf6zlsR5aRkx082KbtfEjecSr8tXkgMG le8ZmQyMI1XZA+CfLexQsqVTs3qbBYYwO4U9NByZEm476KCKqwdRgcl1HhLv4X1ExO a3gR/nJxOC2f6Ivl9EoUTnGl/sONrpPhzvPpC0S1b83bBH4z2yFLaDCC6mhLLwtiLp G+xZf+xRdofhA== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oJ__TfE0IcTd; Sat, 26 Aug 2023 00:55:02 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 27A2483C00; Sat, 26 Aug 2023 00:55:02 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 27A2483C00 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 68E081BF997 for ; Sat, 26 Aug 2023 00:55:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 3ADAC83C00 for ; Sat, 26 Aug 2023 00:55:00 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 3ADAC83C00 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ldpnh4prnq7i for ; Sat, 26 Aug 2023 00:54:59 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp1.osuosl.org (Postfix) with ESMTPS id 91F6F83B3D for ; Sat, 26 Aug 2023 00:54:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 91F6F83B3D Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B567A628CB; Sat, 26 Aug 2023 00:54:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DCC56C433C8; Sat, 26 Aug 2023 00:54:57 +0000 (UTC) Date: Fri, 25 Aug 2023 17:54:56 -0700 From: Jakub Kicinski To: "Drewek, Wojciech" Message-ID: <20230825175456.44051773@kernel.org> In-Reply-To: References: <20230824085459.35998-1-wojciech.drewek@intel.com> <20230824083201.79f79513@kernel.org> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693011298; bh=/yywbGq6ACHFhnVK1HEPC1x6NEHvjwMXNT4AE6QpBpc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TeWq8O4es9uTN7wHQKmtKLZwe41v4hN/Yrigp2WZf+YdtRtAkvpx+lCIkdJ6DWI4w 4SoI9qSjI0htVCG97rEOx2Q9EDFJGrVIgAtJ55IA+v2TQIKIS87jMQGfe56DAQ/ZBS TKKIfmiDlD2ca3U65flk4CUWZmzx6s2ya6dfGt18eKdHpG4NNFA0lzlwXlEiHi8/aK ALCxB4Ot3xFqCu5zaK60qeIygX4zimv17ukrTDXw87qPUXdJ5ssl1dtzXHojB2xQuD U2x7nyJk3PlMEEepqJeGXjFghAbpd6JierHd1P9vgQc6JUi4mTzh3HxiPoWtw10dwL lC3qhVSTYfuNw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=TeWq8O4e Subject: Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: Disable Cage Max Power override X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "netdev@vger.kernel.org" , "idosch@nvidia.com" , "intel-wired-lan@lists.osuosl.org" , "Kitszel, Przemyslaw" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, 25 Aug 2023 11:01:07 +0000 Drewek, Wojciech wrote: > > Can you say more? We have ETHTOOL_MSG_MODULE_GET / SET, sounds like > > something we could quite easily get ethtool to support? > > So you're suggesting that ethtool could support setting the maximum power in the cage? > Something like: > - new "--set-module" parameter called "power-max" > - new "--get-module" parameters: "power-max-allowed", > "power-min-allowed" indicating limitations reported by the HW. Yup. Oh, nice you even CCed Ido already :) > About the patch itself, it's only about restoration of the default > settings upon port split. Those might be overwritten by Intel's > external tools. I guess, the thing that sent me down the path of putting the control in hands of the user more directly was the question of "why do we need to reset on port split"? Why is that a policy the driver is supposed to follow? _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan