From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B6E3E77376 for ; Sat, 30 Sep 2023 16:18:02 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0867B4226E; Sat, 30 Sep 2023 16:18:02 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 0867B4226E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1696090682; bh=o2tdkBxi52bFGUyOPFnWUjRCOQtWbTopZ3pRwODXo48=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=iazm5NYlrpyETeF056sUqcz0jzNfngtVdkQFMQkFJKqNLzCCJULH6x82+qygXFkkp JhSassoeC1++9PciotJd5dfHbhTNTACO5LdDfzxW6G42XCuWU4QW+mYdWrednlUD1b 3aGr9GVEQeWP3keUMmhK0MBnmoPobPIzAdc4j2Sfc0su0K7l1/BBFfb2kQLkWnoVZY ec+QMbf9mBIPtY923/TI1UxOvSWZ3hFSkofADXNga37Uh4FxI5j0VskftM/BcEj37g jGZG04hM8bytN8tMqCnHpySyvtJKJkOcjqi0NMzGlLZOdzJdNYNUl9ygDz2n8ETmin yhLr2Cn16Clxw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nv0hZPR0rBmk; Sat, 30 Sep 2023 16:17:59 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 469C542248; Sat, 30 Sep 2023 16:17:59 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 469C542248 Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 5D86A1BF36F for ; Sat, 30 Sep 2023 16:17:58 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4414183CDF for ; Sat, 30 Sep 2023 16:17:58 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 4414183CDF X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tB9ngsEAGlnB for ; Sat, 30 Sep 2023 16:17:57 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp1.osuosl.org (Postfix) with ESMTPS id 009E583CC6 for ; Sat, 30 Sep 2023 16:17:56 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 009E583CC6 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id F110ECE1D2F; Sat, 30 Sep 2023 16:17:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38E53C433C7; Sat, 30 Sep 2023 16:17:50 +0000 (UTC) Date: Sat, 30 Sep 2023 18:17:48 +0200 From: Simon Horman To: Prasad Koya Message-ID: <20230930161748.GD92317@kernel.org> References: <20230922163804.7DDBA2440449@us122.sjc.aristanetworks.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230922163804.7DDBA2440449@us122.sjc.aristanetworks.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696090672; bh=G8gJlihvipQwNDatoTzGrXw1pQtQJJLuIFbWWRkWTR4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=i109Ka1k9hNFTZwtAreSIxEbGGKNtAvtuVcDnKvQlZ+cvgSkF1p+Wm+OTSBWLaXJA JGGYpNrLcDGQhbV4zSnNzQOjM3Ont/1VNAyBlNLOiotwitWEd3p73ttQQZKzM84hXF foVHqaFw1srxcrxGl1o2SDuNwyUTgRA3+pp9Spr1GHYZGGssYew4uB38J1bRGCLOU2 +p5lOt9NEG1Oxov+CHxAjN4NJlec6kiq4ok9W+RA0c1X9wzBTZ+Tdye7ePTeH9Ab37 xafXoKEQ8eXjEnJHYCqmvo3YumPgseLcaqcuAEQvRjAXuA8yjH0Ln1yX1eMio6gO4y NjVtlXvJKlTsg== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=i109Ka1k Subject: Re: [Intel-wired-lan] [PATCH] [iwl-net] Revert "igc: set TP bit in 'supported' and 'advertising' fields of ethtool_link_ksettings" X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dumazet@google.com, sasha.neftin@intel.com, netdev@vger.kernel.org, jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org, kuba@kernel.org, pabeni@redhat.com, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Fri, Sep 22, 2023 at 09:38:04AM -0700, Prasad Koya wrote: > This reverts commit 9ac3fc2f42e5ffa1e927dcbffb71b15fa81459e2. > > After the command "ethtool -s enps0 speed 100 duplex full autoneg on", > i.e., advertise only 100Mbps speed to the peer, "ethtool enps0" shows > advertised speeds as 100Mbps and 2500Mbps. Same behavior is seen > when changing the speed to 10Mbps or 1000Mbps. > > This applies to I225/226 parts, which only supports copper mode. > Reverting to original till the ambiguity is resolved. > > Fixes: 9ac3fc2f42e5 ("igc: set TP bit in 'supported' and > 'advertising' fields of ethtool_link_ksettings") nit: I don't think it is correct to linewrap Fixes tags. > Signed-off-by: Prasad Koya ... _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan