From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAD4AE8FDBC for ; Tue, 3 Oct 2023 22:43:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9AB5D40103; Tue, 3 Oct 2023 22:43:35 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 9AB5D40103 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1696373015; bh=Np5D8sa8/bbLR/St97gA0x3X0mCCUYusD7RAsm8jkag=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=TNOLRRf3a3pZtiuXYLBcsLrOm7IXwrcIjcZn0szjVmjBmRf4yr8Do0RKhvBQGtbZA qsD++WHlvgQ28LgUqXvmQDRZX2KYotWJzdIjaqnRERGaHojL6wo1lfUszMUB920MD+ bQn4/ICkCV2EJHvZ69pmrWIsDww63y/0rQhHjTxWl7hZShY3L6LhfVgHlv5q+XmryW qCIxUNdVJc1ayYKq1zDmw+okA+65DmgD+UyniSFbNvZQmiBk//fdLJNQSvPEKysrDU vfiVQtRdXr7iDzw5SI0KEaCNcJ9AhOyv4a8SPTGPSilEkKNwsJ9aMl3sd56cdr555D 7QeerqQ/P0RwQ== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0pSyZhG726_M; Tue, 3 Oct 2023 22:43:34 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id DFA8040169; Tue, 3 Oct 2023 22:43:33 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org DFA8040169 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 332AC1BF282 for ; Tue, 3 Oct 2023 22:43:32 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id F3F3441F8E for ; Tue, 3 Oct 2023 22:43:31 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org F3F3441F8E X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id E01E_xmcRK7l for ; Tue, 3 Oct 2023 22:43:30 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by smtp4.osuosl.org (Postfix) with ESMTPS id 9770B41F47 for ; Tue, 3 Oct 2023 22:43:30 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9770B41F47 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 5F385B81C8A; Tue, 3 Oct 2023 22:43:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 261DFC433C7; Tue, 3 Oct 2023 22:43:27 +0000 (UTC) Date: Tue, 3 Oct 2023 15:43:26 -0700 From: Jakub Kicinski To: Tony Nguyen Message-ID: <20231003154326.213e9c81@kernel.org> In-Reply-To: <1430f3d3-4e84-b0ec-acd9-8a51db178f73@intel.com> References: <20230925155858.651425-1-arnd@kernel.org> <1430f3d3-4e84-b0ec-acd9-8a51db178f73@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696373007; bh=P9+3h53DxqmjxSGM6n93lGmt0Puqp/z5dcxCLS1WDnI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BV9UcaP+hpFCnN6I9ENoevhcCLjhYTmYkkTHvkZ7qT3q1yIOZ98ANL+SXHfo7mzRb 7zgNftxObRPKY49gRz7tKnuh4BIQm/4VubbU7y7z+0n1Fv41KiY7MdBRGrs5ad8Bl+ TQhg6JuSB9C37B/Zf4wnluiEOAm7u3R0H1Z0L9lE/rpnHkxB0jAcVl62S2NArkiZCr 5ygtHz4EYQty6Jqd9nQrYGM0bVAWzQOKo0IrvwnqcoCXsdCQFWxwChtCEnKQA31z7E vX0gevM+gdjc2x33GbNGLauYLuvVAnWa9zoi5zkt63mT+2C3XBwkhDnkC3yGjAxxex t1BN62AP7U3IA== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=BV9UcaP+ Subject: Re: [Intel-wired-lan] [PATCH] idpf: fix building without IPv4 X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Willem de Bruijn , Arnd Bergmann , Sridhar Samudrala , Joshua Hay , Madhu Chittim , Jesse Brandeburg , linux-kernel@vger.kernel.org, Alexander Lobakin , Eric Dumazet , Pavan Kumar Linga , "Lobakin, Alexandr" , Alan Brady , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Phani Burra , Paolo Abeni , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 25 Sep 2023 10:05:03 -0700 Tony Nguyen wrote: > Also, a pending patch for this [1], however, this does look a bit more > efficient. Adding Olek as he's author on the other patch. > > netdev maintainers, > > If this is the version that does get picked up, did you want to take it > directly to close out the compile issues? Sorry for the delays. Should we not add a !INET static inline wrapper for tcp_gro_complete()? Seems a bit backwards to me to make drivers suffer and think about such a preposterous config :S $ git grep tcp_gro_complete -- drivers/ drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c: tcp_gro_complete(skb); drivers/net/ethernet/broadcom/bnxt/bnxt.c: tcp_gro_complete(skb); drivers/net/ethernet/intel/idpf/idpf_txrx.c: tcp_gro_complete(skb); drivers/net/ethernet/qlogic/qede/qede_fp.c: tcp_gro_complete(skb); We have 4 drivers which need ifdefs already and the number will only grow with GRO-HW spreading. _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan