From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9728DCD98E5 for ; Wed, 11 Oct 2023 02:10:29 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 3AB0A4047C; Wed, 11 Oct 2023 02:10:29 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 3AB0A4047C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1696990229; bh=RLGhS4HeXMKedXMBgpYhLZCdhjbecdbA1kxTGCj0w4Q=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=9R438291nI5+Rc+vs8G05f7iyw15EgDh+GGcK2XIW8Cy1/2TyD24S9YdaByNuWBta EYouYwyTnnJuKEAglL0DqUBh6Yzy5yBwcg12vBavDxBM0Ug37bWpPrF3XtLAt6CQTT HhyLp+2Ur05pNEo/X99Jomn1PcHCGjZHSNtS3PgHNQAgt0Y60ichkbCaa3b1cV4trZ DqPlP77VAJpMX8stHIdTwhCQSfPYA6wzk4rInKTiAO+sWZMTDAYPD2BQSkPKwdCcO5 KfQyX3xe0uu6MlDKb8g+Rqji8Di9ZJ1IE4znX//OwNQv4idwCWZDysicLKzKENERkH KixQbvI6qVLFw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fEIilXylzSdQ; Wed, 11 Oct 2023 02:10:26 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id A0CA6404BF; Wed, 11 Oct 2023 02:10:26 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org A0CA6404BF Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 277CE1BF292 for ; Wed, 11 Oct 2023 02:10:25 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id F3D614047C for ; Wed, 11 Oct 2023 02:10:24 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org F3D614047C X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ye7lZ7lE6rAG for ; Wed, 11 Oct 2023 02:10:23 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp2.osuosl.org (Postfix) with ESMTPS id 0F3EE4158B for ; Wed, 11 Oct 2023 02:10:22 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 0F3EE4158B Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 99C2561026; Wed, 11 Oct 2023 02:10:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B1D5DC433C8; Wed, 11 Oct 2023 02:10:20 +0000 (UTC) Date: Tue, 10 Oct 2023 19:10:19 -0700 From: Jakub Kicinski To: takeru hayasaka Message-ID: <20231010191019.12fb7071@kernel.org> In-Reply-To: References: <20231008075221.61863-1-hayatake396@gmail.com> <20231010123235.4a6498da@kernel.org> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696990221; bh=SCN+YvrTAvn/rzETs6OSh7GFIZOLCdOcc5xTG+BWl0g=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=A0n2bizFMpZqqKeGhyfo1ozKH4zwv1E5WO/KuO+JorM7wXzRM6u21i+SvPPYJPSgL 8IqhnLJh5EdIJKh+kVXpg8RCAGy8fiWXmjx6wag+lF9y2PDpt33HpFV6iz8JSsWBIM QFyLHie+TUizdXcW9qnZcCeEwjxw3/2lrXoEwz9cZ1ctYvcWrhSBPQmqeaysAwknlh BUkjjBOydhkCOQvKK2JxDXFKCCFNMJ5XcTXWPK8kz/gRCkT8fW47b9auOrDVAGrzGQ vzgylqoG1XQ39ay/nXMofyJqIkddLIywkojM3gpXsJy4O0dYN98IQuVdgltPbH1/Ag 0z1PUB0veiV3A== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=A0n2bizF Subject: Re: [Intel-wired-lan] [PATCH net-next] ethtool: ice: Support for RSS settings to GTP from ethtool X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Jesse Brandeburg , linux-kernel@vger.kernel.org, Eric Dumazet , intel-wired-lan@lists.osuosl.org, Tony Nguyen , Paolo Abeni , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Wed, 11 Oct 2023 10:56:17 +0900 takeru hayasaka wrote: > GTP generates a flow that includes an ID called TEID to identify the > tunnel. This tunnel is created for each UE (User Equipment). > By performing RSS based on this flow, it is possible to apply RSS for > each communication unit from the UE. > Without this, RSS would only be effective within the range of IP addresses. > For instance, the PGW can only perform RSS within the IP range of the SGW. > What I'm trying to say is that RSS based solely on IP addresses can be > problematic from a load distribution perspective, especially if > there's a bias in the terminals connected to a particular base > station. > As a reference that discusses a similar topic, please see the link > below(is not RSS, is TEID Flow): > https://docs.nvidia.com/networking-ethernet-software/cumulus-linux-56/Layer-3/Routing/Equal-Cost-Multipath-Load-Sharing/#gtp-hashing Makes sense, thanks for the extra information. I think it would be worth adding all of this to the commit message! Regarding the patch - you are only adding flow types, not a new field (which are defined as RXH_*). If we want to hash on an extra field, I think we need to specify that field as well? > Thank you for your understanding. > --- > Sorry! My email was blocked because it wasn't sent in plain text mode. > I've made the necessary changes and will resend it. No worries! Additional request - in the future please prefer the bottom-posting or interleaved style of replies: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan