From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C4A5CDB465 for ; Mon, 16 Oct 2023 15:02:10 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id EC3E0408F7; Mon, 16 Oct 2023 15:02:09 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org EC3E0408F7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1697468530; bh=GE4ET5GQ0PTc+JOTtkvwlW8kP+QEoW3+B39gHyQHPTc=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=jYhc+FdYhg+5vORkD8a2O/klJ5L/gqO/gFyU1nyFprN3UnFF5Mo17alWBXUgIM2r1 1fUar1xA+U3R+FeX+PNUAaMlzSkaFXp6xuE1qOVRM/BJLYsQaQ+S27bApqmi5YHozC klXgjblUHQY4GH7p55bXNGgbsLHgwukPBgnr85vseqUtaYVN6WxGcxuBFM6PHQ3uyz 3dC3PcjUersk5KJXjSfhbFk/1aPHj29ysh1cv+gNYiyU5OLD4tqvefgEPaosXLW+SJ A2i0J+DXys8KcbOLgzDQvKzRpovtYki/mJUk1RbV1iIvbY461ofVlv7HKQCQxnswvN lhau7StrkRhew== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id h4uZvGWY6PBE; Mon, 16 Oct 2023 15:02:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id AE5DF4179D; Mon, 16 Oct 2023 15:02:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org AE5DF4179D Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 5B4D51BF95C for ; Mon, 16 Oct 2023 15:02:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 40BE281E39 for ; Mon, 16 Oct 2023 15:02:06 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 40BE281E39 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LSw3LclpVDWl for ; Mon, 16 Oct 2023 15:02:05 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp1.osuosl.org (Postfix) with ESMTPS id 19CB581E46 for ; Mon, 16 Oct 2023 15:02:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 19CB581E46 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 1942E60FDB; Mon, 16 Oct 2023 15:02:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2663CC433C9; Mon, 16 Oct 2023 15:02:03 +0000 (UTC) Date: Mon, 16 Oct 2023 08:02:02 -0700 From: Jakub Kicinski To: Ahmed Zaki Message-ID: <20231016080202.0d755ef3@kernel.org> In-Reply-To: References: <20231010200437.9794-1-ahmed.zaki@intel.com> <20231010200437.9794-2-ahmed.zaki@intel.com> <8d205051-d04c-42ff-a2c5-98fcd8545ecb@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697468523; bh=J5b7wIkmNDZePcl6689bb1lqUj0fI6CrDKw3d6N9cNQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nwE77uyMYSNbphoXAWn6ygCBN9Q7OQRXv+tz+SPnRISF379jWyUQyfomoc1+mxW+P NIZnRfAqC7tevyg0mOTjTv782qCPLA07+i1UgcSqJvOt9JSMVDjEwOCv2uPKAtxvmY vJRzQTj1EvdV5oQGdwUkT8mhnpJyD3Rl0m935hTPR6wFmLES/JXnhJs7MscEZtAaY9 0bf7k93jUqoAJ/4bVq0BMXTEeIzsc46z1jqTcU7Ymq752JZSgaQ6nsayyXx0/2P7fB 0qNmHFNfzp6Vtb6D7TS/cXVLLYFRvR0M0fDeIgPzfPK3YyK862ibFTE6AgjLW3C3Bc 34jwcmi6xdGYw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=nwE77uyM Subject: Re: [Intel-wired-lan] [PATCH net-next v3 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mkubecek@suse.cz, andrew@lunn.ch, Willem de Bruijn , Wojciech Drewek , corbet@lwn.net, netdev@vger.kernel.org, linux-doc@vger.kernel.org, jesse.brandeburg@intel.com, edumazet@google.com, anthony.l.nguyen@intel.com, horms@kernel.org, vladimir.oltean@nxp.com, intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Sat, 14 Oct 2023 06:19:54 -0600 Ahmed Zaki wrote: > >> +#define RXH_SYMMETRIC_XOR (1 << 30) > >> +#define RXH_DISCARD (1 << 31) > >> > >> Are these indentation changes intentional? > >> > >> > >> Yes, for alignment ("RXH_SYMMETRIC_XOR" is too long). > > > > I think it's preferable to not touch other lines. Among others, that > > messes up git blame. But it's subjective. Follow your preference if no > > one else chimes in. > > Jakub, > > Sorry for late reply, I was off for few days. > > I'd like to keep this version, I don't see any other comments that needs > to be addressed. Can you accept this or need a v4/rebase ? I think you should add a comment above the define explaining what "symmetric-xor" is. Is this correct? /* XOR corresponding source and destination fields, both copies * of the XOR'ed fields are fed into the RSS and RXHASH calculation. */ _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan