From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0692CDB465 for ; Mon, 16 Oct 2023 23:31:09 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 81850818BE; Mon, 16 Oct 2023 23:31:09 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org 81850818BE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1697499069; bh=rQxidznPR7nHB8sL/MB4v1f/VXDSA29LMv1/MhUTEGY=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=7+U9beIbRwh8QDR3ExBikm1MK/eJRiTYXO01SRcDdF8ZYMH3KAILX83tg53l2Dbd2 qS0ma3DOTI3ccxQAqHyo0fgDsXA8zjiXxB3uZGHBgz5gcGJuY7Qs+OYRJ02NEMGhXz OgmsNyaOFpwLMeykfoX3LsFjXlSDJB+9+ub4AB4H16QFNhCEsNFknGiPIuxaudy732 NJhW0q05UQ3D85bMRc7xWJjEqw9RuHgODVKFYrx/UWMQTmg2JEWwMEz6JE+lxHQdWu /+2E4YCpWprIAGwp4Owlr1Sz08X+08ub+15mjuEWXm1z/BQK8SFr8B/fSiROicJWPd KpK02HpSh383w== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sRr6MkNrCnfW; Mon, 16 Oct 2023 23:31:08 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id ACA28818C0; Mon, 16 Oct 2023 23:31:08 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org ACA28818C0 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id D9EA81BF3BE for ; Mon, 16 Oct 2023 23:31:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id B17DE417AE for ; Mon, 16 Oct 2023 23:31:06 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org B17DE417AE X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rR9N49j9ZGb7 for ; Mon, 16 Oct 2023 23:31:06 +0000 (UTC) Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by smtp4.osuosl.org (Postfix) with ESMTPS id F3C904179A for ; Mon, 16 Oct 2023 23:31:05 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org F3C904179A Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id D4E1FCE1B7A; Mon, 16 Oct 2023 23:31:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4DF2FC433C7; Mon, 16 Oct 2023 23:31:00 +0000 (UTC) Date: Mon, 16 Oct 2023 16:30:59 -0700 From: Jakub Kicinski To: Alexander Duyck Message-ID: <20231016163059.23799429@kernel.org> In-Reply-To: References: <20231016154937.41224-1-ahmed.zaki@intel.com> <20231016154937.41224-2-ahmed.zaki@intel.com> <8d1b1494cfd733530be887806385cde70e077ed1.camel@gmail.com> <26812a57-bdd8-4a39-8dd2-b0ebcfd1073e@intel.com> <14feb89d-7b4a-40c5-8983-5ef331953224@intel.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697499061; bh=nwdQBoh44SzFZ2rYCp83ea7TerdiBs+GYGKIDM09S/Q=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sR/3zAHs90iIH3UGAt+nf8mUNK0JcfcAd6Appi9qlpPZrtS8fuGRSOmrY+oEHir6g 5HN+LIFvW/X4MS1PyLdykc9TmMUnJ3TFpU/j53mjExdqeBocAh42VPMeECx6p3QESQ vaExacPpd0zMgg3zQ8uqdJ9wjOsuIZG5C2+AwNIgQw6i0dxevP7EJLj5sxUewVymi6 ecJ5nGj1DCx4WFdoOVEHokIPD/aOVbqOJx4/z/mFB83gsnQp1srFho/Mm0G1k0vuo9 ZCk+AKToCpvMWmsH4eQXXFzBLQ9bfSS0v/9hjpVM9JfA0WbQJ3ABnX9L8t26oy+0Hg DbweH3VCR7ODg== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=sR/3zAHs Subject: Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mkubecek@suse.cz, andrew@lunn.ch, willemdebruijn.kernel@gmail.com, Wojciech Drewek , corbet@lwn.net, netdev@vger.kernel.org, linux-doc@vger.kernel.org, jesse.brandeburg@intel.com, Ahmed Zaki , edumazet@google.com, anthony.l.nguyen@intel.com, horms@kernel.org, vladimir.oltean@nxp.com, intel-wired-lan@lists.osuosl.org, pabeni@redhat.com, davem@davemloft.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, 16 Oct 2023 15:55:21 -0700 Alexander Duyck wrote: > It would make more sense to just add it as a variant hash function of > toeplitz. If you did it right you could probably make the formatting > pretty, something like: > RSS hash function: > toeplitz: on > symmetric xor: on > xor: off > crc32: off > > It doesn't make sense to place it in the input flags and will just > cause quick congestion as things get added there. This is an algorithm > change so it makes more sense to place it there. Algo is also a bit confusing, it's more like key pre-processing? There's nothing toeplitz about xoring input fields. Works as well for CRC32.. or XOR. We can use one of the reserved fields of struct ethtool_rxfh to carry this extension. I think I asked for this at some point, but there's only so much repeated feedback one can send in a day :( _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan