From: Michal Schmidt <mschmidt@redhat.com>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, Tony Nguyen <anthony.l.nguyen@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: [Intel-wired-lan] [PATCH iwl-next 2/4] iavf: use unregister_netdev
Date: Mon, 16 Oct 2023 18:48:47 +0200 [thread overview]
Message-ID: <20231016164849.45691-3-mschmidt@redhat.com> (raw)
In-Reply-To: <20231016164849.45691-1-mschmidt@redhat.com>
Use unregister_netdev, which takes rtnl_lock for us. We don't have to
check the reg_state under rtnl_lock. There's nothing to race with. We
have just cancelled the finish_config work.
Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
---
drivers/net/ethernet/intel/iavf/iavf_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c b/drivers/net/ethernet/intel/iavf/iavf_main.c
index d2f4648a6156..6036a4582196 100644
--- a/drivers/net/ethernet/intel/iavf/iavf_main.c
+++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
@@ -5171,10 +5171,8 @@ static void iavf_remove(struct pci_dev *pdev)
cancel_delayed_work_sync(&adapter->watchdog_task);
cancel_work_sync(&adapter->finish_config);
- rtnl_lock();
if (netdev->reg_state == NETREG_REGISTERED)
- unregister_netdevice(netdev);
- rtnl_unlock();
+ unregister_netdev(netdev);
if (CLIENT_ALLOWED(adapter)) {
err = iavf_lan_del_device(adapter);
--
2.41.0
_______________________________________________
Intel-wired-lan mailing list
Intel-wired-lan@osuosl.org
https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
next prev parent reply other threads:[~2023-10-16 16:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 16:48 [Intel-wired-lan] [PATCH iwl-next 0/4] iavf: cleanups, dead code removal Michal Schmidt
2023-10-16 16:48 ` [Intel-wired-lan] [PATCH iwl-next 1/4] iavf: rely on netdev's own registered state Michal Schmidt
2023-10-17 8:01 ` Drewek, Wojciech
2023-10-17 17:30 ` Jacob Keller
2023-10-24 9:09 ` Romanowski, Rafal
2023-10-16 16:48 ` Michal Schmidt [this message]
2023-10-17 8:06 ` [Intel-wired-lan] [PATCH iwl-next 2/4] iavf: use unregister_netdev Drewek, Wojciech
2023-10-24 9:11 ` Romanowski, Rafal
2023-10-17 17:33 ` Jacob Keller
2023-10-17 18:43 ` Jacob Keller
2023-10-16 16:48 ` [Intel-wired-lan] [PATCH iwl-next 3/4] iavf: add a common function for undoing the interrupt scheme Michal Schmidt
2023-10-17 8:58 ` Drewek, Wojciech
2023-10-17 17:35 ` Jacob Keller
2023-10-24 9:12 ` Romanowski, Rafal
2023-10-16 16:48 ` [Intel-wired-lan] [PATCH iwl-next 4/4] iavf: delete the iavf client interface Michal Schmidt
2023-10-17 17:46 ` Jacob Keller
2023-10-24 9:12 ` Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231016164849.45691-3-mschmidt@redhat.com \
--to=mschmidt@redhat.com \
--cc=anthony.l.nguyen@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox